From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: [PATCH 02/13] tty: serial: 8250: make serial8250_console_setup() non _init Date: Mon, 29 Sep 2014 20:06:38 +0200 Message-ID: <1412014009-13315-3-git-send-email-bigeasy@linutronix.de> References: <1412014009-13315-1-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1412014009-13315-1-git-send-email-bigeasy@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com, balbi@ti.com, gregkh@linuxfoundation.org, Sebastian Andrzej Siewior List-Id: linux-omap@vger.kernel.org if I boot with console=3DttyS0 and the omap driver is module I end up w= ith | console [ttyS0] disabled | omap8250 44e09000.serial: ttyS0 at MMIO 0x44e09000 (irq =3D 88, base_= baud =3D 3000000) is a 8250 | Unable to handle kernel paging request at virtual address c07a9de0 | Modules linked in: 8250_omap(+) | CPU: 0 PID: 908 Comm: modprobe Not tainted 3.17.0-rc5+ #1593 | PC is at serial8250_console_setup+0x0/0xc8 | LR is at register_console+0x13c/0x3a4 | [] (register_console) from [] (uart_add_one_port+= 0x3cc/0x420) | [] (uart_add_one_port) from [] (serial8250_regist= er_8250_port+0x298/0x39c) | [] (serial8250_register_8250_port) from [] (omap8= 250_probe+0x218/0x3dc [8250_omap]) | [] (omap8250_probe [8250_omap]) from [] (platform= _drv_probe+0x2c/0x5c) | [] (platform_drv_probe) from [] (driver_probe_dev= ice+0x104/0x228) =E2=80=A6 | [] (SyS_init_module) from [] (ret_fast_syscall+0x= 0/0x30) | Code: 7823603b f8314620 051b3013 491ed416 (44792204) because serial8250_console_setup() is already gone. Signed-off-by: Sebastian Andrzej Siewior --- drivers/tty/serial/8250/8250_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8= 250/8250_core.c index a1904628a2a1..159b72471622 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -3237,7 +3237,7 @@ serial8250_console_write(struct console *co, cons= t char *s, unsigned int count) serial8250_rpm_put(up); } =20 -static int __init serial8250_console_setup(struct console *co, char *o= ptions) +static int serial8250_console_setup(struct console *co, char *options) { struct uart_port *port; int baud =3D 9600; --=20 2.1.0