[PATCH] ARM: OMAP2: Remove unnecessary KERN_* in omap_phy_internal.c

[PATCH] ARM: OMAP2: Remove unnecessary KERN_* in omap_phy_internal.c

[Masanari Iida]

This patch remove unnecessary KERN_INFO and KERN_ERR from omap_phy_internal.c.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 arch/arm/mach-omap2/omap_phy_internal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
index 50640b3..f4d942a 100644
--- a/arch/arm/mach-omap2/omap_phy_internal.c
+++ b/arch/arm/mach-omap2/omap_phy_internal.c
@@ -97,13 +97,13 @@ void am35x_musb_phy_power(u8 on)
 
 		omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
 
-		pr_info(KERN_INFO "Waiting for PHY clock good...\n");
+		pr_info("Waiting for PHY clock good...\n");
 		while (!(omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2)
 				& CONF2_PHYCLKGD)) {
 			cpu_relax();
 
 			if (time_after(jiffies, timeout)) {
-				pr_err(KERN_ERR "musb PHY clock good timed out\n");
+				pr_err("musb PHY clock good timed out\n");
 				break;
 			}
 		}
@@ -145,7 +145,7 @@ void am35x_set_mode(u8 musb_mode)
 		devconf2 |= CONF2_NO_OVERRIDE;
 		break;
 	default:
-		pr_info(KERN_INFO "Unsupported mode %u\n", musb_mode);
+		pr_info("Unsupported mode %u\n", musb_mode);
 	}
 
 	omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
-- 
2.1.1.273.g97b8860

Re: [PATCH] ARM: OMAP2: Remove unnecessary KERN_* in omap_phy_internal.c

[Nishanth Menon]

On 01:16-20141007, Masanari Iida wrote:
> This patch remove unnecessary KERN_INFO and KERN_ERR from omap_phy_internal.c.
> 
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  arch/arm/mach-omap2/omap_phy_internal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
> index 50640b3..f4d942a 100644
> --- a/arch/arm/mach-omap2/omap_phy_internal.c
> +++ b/arch/arm/mach-omap2/omap_phy_internal.c

With the cleanups, maybe add a
#define pr_fmt(fmt) "%s: " fmt, __func__
at the start to make the log info a little more relevant?

> @@ -97,13 +97,13 @@ void am35x_musb_phy_power(u8 on)
>  
>  		omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
>  
> -		pr_info(KERN_INFO "Waiting for PHY clock good...\n");
> +		pr_info("Waiting for PHY clock good...\n");
>  		while (!(omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2)
>  				& CONF2_PHYCLKGD)) {
>  			cpu_relax();
>  
>  			if (time_after(jiffies, timeout)) {
> -				pr_err(KERN_ERR "musb PHY clock good timed out\n");
> +				pr_err("musb PHY clock good timed out\n");
>  				break;
>  			}
>  		}
> @@ -145,7 +145,7 @@ void am35x_set_mode(u8 musb_mode)
>  		devconf2 |= CONF2_NO_OVERRIDE;
>  		break;
>  	default:
> -		pr_info(KERN_INFO "Unsupported mode %u\n", musb_mode);
> +		pr_info("Unsupported mode %u\n", musb_mode);
>  	}
>  
>  	omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
> -- 
> 2.1.1.273.g97b8860
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Regards,
Nishanth Menon

[PATCH/v2] ARM: OMAP2: Remove unnecessary KERN_* in omap_phy_internal.c

[Masanari Iida]

This patch remove unnecessary KERN_INFO and KERN_ERR from omap_phy_internal.c.
Add pr_fmt. 

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
 arch/arm/mach-omap2/omap_phy_internal.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c
index 50640b3..1a19fa0 100644
--- a/arch/arm/mach-omap2/omap_phy_internal.c
+++ b/arch/arm/mach-omap2/omap_phy_internal.c
@@ -21,6 +21,8 @@
   *
   */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/types.h>
 #include <linux/delay.h>
 #include <linux/clk.h>
@@ -97,13 +99,13 @@ void am35x_musb_phy_power(u8 on)
 
 		omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
 
-		pr_info(KERN_INFO "Waiting for PHY clock good...\n");
+		pr_info("Waiting for PHY clock good...\n");
 		while (!(omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2)
 				& CONF2_PHYCLKGD)) {
 			cpu_relax();
 
 			if (time_after(jiffies, timeout)) {
-				pr_err(KERN_ERR "musb PHY clock good timed out\n");
+				pr_err("musb PHY clock good timed out\n");
 				break;
 			}
 		}
@@ -145,7 +147,7 @@ void am35x_set_mode(u8 musb_mode)
 		devconf2 |= CONF2_NO_OVERRIDE;
 		break;
 	default:
-		pr_info(KERN_INFO "Unsupported mode %u\n", musb_mode);
+		pr_info("Unsupported mode %u\n", musb_mode);
 	}
 
 	omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
-- 
2.1.1.273.g97b8860

Re: [PATCH/v2] ARM: OMAP2: Remove unnecessary KERN_* in omap_phy_internal.c

[Tony Lindgren]

* Masanari Iida <standby24x7@gmail.com> [141007 07:17]:
> This patch remove unnecessary KERN_INFO and KERN_ERR from omap_phy_internal.c.
> Add pr_fmt. 

Applying into omap-for-v3.19/fixes-not-urgent thanks.

Tony