From: Roger Quadros <rogerq@ti.com>
To: paul@pwsan.com, tony@atomide.com
Cc: nm@ti.com, j-keerthy@ti.com, t-kristo@ti.com,
linux-omap@vger.kernel.org, Roger Quadros <rogerq@ti.com>
Subject: [PATCH 2/2] ARM: DRA7: hwmod: Fix GPMC from preventing core suspend
Date: Tue, 2 Jun 2015 13:02:53 +0300 [thread overview]
Message-ID: <1433239373-14653-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1433239373-14653-1-git-send-email-rogerq@ti.com>
GPMC hwmod is flagged as HWMOD_INIT_NO_IDLE so it is kept
enabled at boot. If the GPMC driver is not loaded then
GPMC will not be idled thus preventing CORE from going idle
during suspend.
Disable HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET.
The only reason HWMOD_INIT_NO_RESET was there was to retain
GPMC timings/settings configured by bootloader. We no longer
need that as we're configuring the timins in the kernel.
There is no reasoning as to why HWMOD_INIT_NO_IDLE was there.
Seems to have beein blindly copied from omap3/4 hwmod code.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 8c2fad5..52c6565 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -819,7 +819,6 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
.name = "gpmc",
.class = &dra7xx_gpmc_hwmod_class,
.clkdm_name = "l3main1_clkdm",
- .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
.main_clk = "l3_iclk_div",
.prcm = {
.omap4 = {
--
2.1.4
next prev parent reply other threads:[~2015-06-02 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 10:02 [PATCH 0/2] ARM: DRA7: hwmod: fix gpmc hwmod for core-retention Roger Quadros
2015-06-02 10:02 ` [PATCH 1/2] ARM: DRA7: hwmod: fix gpmc hwmod Roger Quadros
2015-06-02 21:34 ` Paul Walmsley
2015-06-10 12:44 ` Roger Quadros
2015-06-03 12:38 ` [PATCH v2 1/1] " Roger Quadros
2015-06-02 10:02 ` Roger Quadros [this message]
2015-06-02 21:36 ` [PATCH 2/2] ARM: DRA7: hwmod: Fix GPMC from preventing core suspend Paul Walmsley
2015-06-03 10:51 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433239373-14653-3-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox