From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: alsa-devel@alsa-project.org
Cc: "Girdwood, Liam" <lrg@ti.com>, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Cousson, Benoit" <b-cousson@ti.com>,
"Guiriec, Sebastien" <s-guiriec@ti.com>,
"Sebastien@alsa-project.org" <Sebastien@alsa-project.org>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>,
"Misael@alsa-project.org" <Misael@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH 4/4] ASoC: OMAP4: McPDM: Convert to hwmod/omap_device
Date: Wed, 3 Aug 2011 10:58:13 +0300 [thread overview]
Message-ID: <1433314.EB2v33lUYq@barack> (raw)
In-Reply-To: <1312284857-1774-5-git-send-email-peter.ujfalusi@ti.com>
On Tuesday 02 August 2011 13:34:17 Ujfalusi, Peter wrote:
> In order to probe, and operate correctly, the OMAP McPDM driver needs to
> be converted to use hwmod.
> The device name has been changed to probe the driver.
> Replace the clk_* with pm_runtime_* calls to manage the clocks correctly.
> Missing request_mem_region/release_mem_region added.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> sound/soc/omap/mcpdm.c | 38 +++++++++++++++++++++-----------------
> sound/soc/omap/mcpdm.h | 1 -
> sound/soc/omap/omap-mcpdm.c | 2 +-
> sound/soc/omap/sdp4430.c | 2 +-
> 4 files changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/sound/soc/omap/mcpdm.c b/sound/soc/omap/mcpdm.c
> index 928f037..d29cc98 100644
> --- a/sound/soc/omap/mcpdm.c
> +++ b/sound/soc/omap/mcpdm.c
> @@ -28,7 +28,7 @@
> #include <linux/slab.h>
> #include <linux/interrupt.h>
> #include <linux/err.h>
> -#include <linux/clk.h>
> +#include <linux/pm_runtime.h>
> #include <linux/delay.h>
> #include <linux/io.h>
> #include <linux/irq.h>
> @@ -322,11 +322,11 @@ static irqreturn_t omap_mcpdm_irq_handler(int irq,
> void *dev_id) return IRQ_HANDLED;
> }
>
> -int omap_mcpdm_request(void)
> + int omap_mcpdm_request(void)
Just noticed this one.
Going to resend, or Liam can you fix this up when you take the patches?
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-03 7:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 11:34 [PATCH 0/4] ASoC: OMAP4: McPDM: Fix legacy support Peter Ujfalusi
2011-08-02 11:34 ` [PATCH 1/4] OMAP: McPDM: Convert McPDM device to omap_device Peter Ujfalusi
2011-08-19 13:02 ` Tony Lindgren
2011-08-02 11:34 ` [PATCH 2/4] OMAP4: hwmod: enable mcpdm hwmod device Peter Ujfalusi
2011-08-19 13:02 ` Tony Lindgren
2011-08-02 11:34 ` [PATCH 3/4] ASoC: omap-mcpdm: Fix threshold and dma configuration Peter Ujfalusi
2011-08-02 15:50 ` Mark Brown
2011-08-02 11:34 ` [PATCH 4/4] ASoC: OMAP4: McPDM: Convert to hwmod/omap_device Peter Ujfalusi
2011-08-02 16:07 ` Mark Brown
2011-08-03 7:58 ` Péter Ujfalusi [this message]
2011-08-09 7:27 ` [alsa-devel] [PATCH 0/4] ASoC: OMAP4: McPDM: Fix legacy support Péter Ujfalusi
2011-08-15 11:28 ` Péter Ujfalusi
2011-08-19 13:04 ` Re: [alsa-devel] " Tony Lindgren
2011-08-22 7:13 ` Péter Ujfalusi
2011-08-22 7:38 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433314.EB2v33lUYq@barack \
--to=peter.ujfalusi@ti.com \
--cc=Misael@alsa-project.org \
--cc=Sebastien@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=s-guiriec@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox