linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Franklin S Cooper Jr <fcooper@ti.com>
To: linux-kernel@vger.kernel.org, rogerq@ti.com,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-mtd@lists.infradead.org, nsekhar@ti.com,
	computersforpeace@gmail.com, dwmw2@infradead.org,
	tony@atomide.com
Cc: Franklin S Cooper Jr <fcooper@ti.com>
Subject: [PATCH v2 3/5] mtd: nand: omap2: Fix high memory dma prefetch transfer
Date: Thu, 15 Oct 2015 12:37:26 -0500	[thread overview]
Message-ID: <1444930648-19313-4-git-send-email-fcooper@ti.com> (raw)
In-Reply-To: <1444930648-19313-1-git-send-email-fcooper@ti.com>

Based on DMA documentation and testing using high memory buffer when
doing dma transfers can lead to various issues including kernel
panics.

To workaround this simply use cpu copy. The amount of high memory
buffers used are very uncommon so no noticeable performance hit should
be seen.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
V2 Changes:
None

 drivers/mtd/nand/omap2.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 1f58420..0d2cbb0 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -479,17 +479,8 @@ static inline int omap_nand_dma_transfer(struct mtd_info *mtd, void *addr,
 	int ret;
 	u32 val;
 
-	if (addr >= high_memory) {
-		struct page *p1;
-
-		if (((size_t)addr & PAGE_MASK) !=
-			((size_t)(addr + len - 1) & PAGE_MASK))
-			goto out_copy;
-		p1 = vmalloc_to_page(addr);
-		if (!p1)
-			goto out_copy;
-		addr = page_address(p1) + ((size_t)addr & ~PAGE_MASK);
-	}
+	if (addr >= high_memory)
+		goto out_copy;
 
 	sg_init_one(&sg, addr, len);
 	n = dma_map_sg(info->dma->device->dev, &sg, 1, dir);
@@ -546,6 +537,7 @@ out_copy:
 	else
 		is_write == 0 ? omap_read_buf8(mtd, (u_char *) addr, len)
 			: omap_write_buf8(mtd, (u_char *) addr, len);
+
 	return 0;
 }
 
-- 
2.6.1

  parent reply	other threads:[~2015-10-15 17:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 17:37 [PATCH v2 0/5] mtd: nand: Fix support for NAND DMA prefetch Franklin S Cooper Jr
2015-10-15 17:37 ` [PATCH v2 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Franklin S Cooper Jr
2015-10-15 17:37 ` [PATCH v2 2/5] mtd: nand: omap2: Start dma request before enabling prefetch Franklin S Cooper Jr
2015-10-15 17:37 ` Franklin S Cooper Jr [this message]
2015-10-15 17:37 ` [PATCH v2 4/5] ARM: dts: am437x/am33xx/omap/dm816x: Add gpmc dma channel Franklin S Cooper Jr
2015-11-30 19:06   ` Tony Lindgren
2015-10-15 17:37 ` [PATCH v2 5/5] ARM: OMAP2+: Update GPMC and NAND DT binding documentation Franklin S Cooper Jr
2015-10-16  8:11 ` [PATCH v2 0/5] mtd: nand: Fix support for NAND DMA prefetch Roger Quadros
     [not found] ` <1444930648-19313-1-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2015-12-18 18:04   ` Brian Norris
     [not found]     ` <20151218180434.GJ10460-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-12-30 14:24       ` Franklin S Cooper Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444930648-19313-4-git-send-email-fcooper@ti.com \
    --to=fcooper@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).