From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: broonie@kernel.org
Cc: tony@atomide.com, lgirdwood@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Subject: [PATCH] regulator: twl: Fix a typo in twl4030_send_pb_msg
Date: Wed, 6 Apr 2016 09:06:03 +0300 [thread overview]
Message-ID: <1459922763-14775-1-git-send-email-ivo.g.dimitrov.75@gmail.com> (raw)
In-Reply-To: <57043B87.20304@gmail.com>
Commit <2330b05c095bdeaaf1261c54cd2d4b9127496996> ("regulator: twl: Make
sure we have access to powerbus before trying to write to it")
has implemented the needed logic to correctly access powerbus through i2c,
however it brought a typo when powerbus configuration is restored, which
results in writing to a wrong register. Fix that by providing the correct
register value.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
drivers/regulator/twl-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 11c6a5c..faeb5ee 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -253,7 +253,7 @@ static int twl4030_send_pb_msg(unsigned msg)
/* Restore powerbus configuration */
return twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
- TWL_MODULE_PM_MASTER);
+ TWL4030_PM_MASTER_PB_CFG);
}
static int twl4030reg_enable(struct regulator_dev *rdev)
--
1.9.1
next prev parent reply other threads:[~2016-04-06 6:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 8:28 [PATCH 0/3] regulator: twl: Fix regulator mode support Ivaylo Dimitrov
2016-03-26 8:28 ` [PATCH 1/3] regulator: twl: Make sure we have access to powerbus before trying to write to it Ivaylo Dimitrov
2016-04-05 22:26 ` Ivaylo Dimitrov
2016-04-06 6:06 ` Ivaylo Dimitrov [this message]
2016-04-24 16:10 ` Pavel Machek
2016-04-24 17:14 ` Ivaylo Dimitrov
2016-03-26 8:28 ` [PATCH 2/3] regulator: twl: Provide of_map_mode for twl4030 Ivaylo Dimitrov
2016-03-28 9:39 ` Mark Brown
[not found] ` <20160328093938.GA2350-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-04 18:57 ` [PATCH] " Ivaylo Dimitrov
2016-04-04 22:26 ` Mark Brown
2016-04-05 5:59 ` [PATCH v1] " Ivaylo Dimitrov
2016-04-07 17:57 ` Rob Herring
2016-04-08 15:49 ` Tony Lindgren
[not found] ` <20160408154907.GT16484-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-08 16:08 ` Sebastian Reichel
2016-04-08 16:19 ` Tony Lindgren
[not found] ` <20160408161923.GW16484-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-08 17:54 ` Tony Lindgren
2016-03-26 8:28 ` [PATCH 3/3] regulator: twl: Regulator mode should not depend on regulator enabled state Ivaylo Dimitrov
2016-04-24 16:11 ` Pavel Machek
2016-04-24 17:01 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459922763-14775-1-git-send-email-ivo.g.dimitrov.75@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).