* [PATCH v3 1/2] net: ethernet: ti: cpsw: remove rx_descs property
2016-06-17 10:25 [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property Ivan Khoronzhuk
@ 2016-06-17 10:25 ` Ivan Khoronzhuk
2016-06-17 10:25 ` [PATCH v3 2/2] Documentation: DT: " Ivan Khoronzhuk
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ivan Khoronzhuk @ 2016-06-17 10:25 UTC (permalink / raw)
To: mugunthanvnm, linux-kernel
Cc: grygorii.strashko, linux-omap, netdev, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, bcousson, tony, devicetree,
Ivan Khoronzhuk
There is no reason in rx_descs property because davinici_cpdma
driver splits pool of descriptors equally between tx and rx channels.
That is, if number of descriptors 256, 128 of them are for rx
channels. While receiving, the descriptor is freed to the pool and
then allocated with new skb. And if in DT the "rx_descs" is set to
64, then 128 - 64 = 64 descriptors are always in the pool and cannot
be used, for tx, for instance. It's not correct resource usage,
better to set it to half of pool, then the rx pool can be used in
full. It will not have any impact on performance, as anyway, the
"redundant" descriptors were unused.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
drivers/net/ethernet/ti/cpsw.c | 13 +++----------
drivers/net/ethernet/ti/cpsw.h | 1 -
drivers/net/ethernet/ti/davinci_cpdma.c | 6 ++++++
drivers/net/ethernet/ti/davinci_cpdma.h | 1 +
4 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index f2a4cd6..8327328 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1277,6 +1277,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
if (!cpsw_common_res_usage_state(priv)) {
struct cpsw_priv *priv_sl0 = cpsw_get_slave_priv(priv, 0);
+ int buf_num;
/* setup tx dma to fixed prio and zero offset */
cpdma_control_set(priv->dma, CPDMA_TX_PRIO_FIXED, 1);
@@ -1304,10 +1305,8 @@ static int cpsw_ndo_open(struct net_device *ndev)
enable_irq(priv->irqs_table[0]);
}
- if (WARN_ON(!priv->data.rx_descs))
- priv->data.rx_descs = 128;
-
- for (i = 0; i < priv->data.rx_descs; i++) {
+ buf_num = cpdma_chan_get_rx_buf_num(priv->dma);
+ for (i = 0; i < buf_num; i++) {
struct sk_buff *skb;
ret = -ENOMEM;
@@ -1998,12 +1997,6 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
}
data->bd_ram_size = prop;
- if (of_property_read_u32(node, "rx_descs", &prop)) {
- dev_err(&pdev->dev, "Missing rx_descs property in the DT.\n");
- return -EINVAL;
- }
- data->rx_descs = prop;
-
if (of_property_read_u32(node, "mac_control", &prop)) {
dev_err(&pdev->dev, "Missing mac_control property in the DT.\n");
return -EINVAL;
diff --git a/drivers/net/ethernet/ti/cpsw.h b/drivers/net/ethernet/ti/cpsw.h
index e50afd1..16b54c6 100644
--- a/drivers/net/ethernet/ti/cpsw.h
+++ b/drivers/net/ethernet/ti/cpsw.h
@@ -35,7 +35,6 @@ struct cpsw_platform_data {
u32 cpts_clock_shift; /* convert input clock ticks to nanoseconds */
u32 ale_entries; /* ale table size */
u32 bd_ram_size; /*buffer descriptor ram size */
- u32 rx_descs; /* Number of Rx Descriptios */
u32 mac_control; /* Mac control register */
u16 default_vlan; /* Def VLAN for ALE lookup in VLAN aware mode*/
bool dual_emac; /* Enable Dual EMAC mode */
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index 18bf3a8..bcd9e45 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -543,6 +543,12 @@ struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num,
}
EXPORT_SYMBOL_GPL(cpdma_chan_create);
+int cpdma_chan_get_rx_buf_num(struct cpdma_ctlr *ctlr)
+{
+ return ctlr->pool->num_desc / 2;
+}
+EXPORT_SYMBOL_GPL(cpdma_chan_get_rx_buf_num);
+
int cpdma_chan_destroy(struct cpdma_chan *chan)
{
struct cpdma_ctlr *ctlr;
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.h b/drivers/net/ethernet/ti/davinci_cpdma.h
index 86dee48..80c015c 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.h
+++ b/drivers/net/ethernet/ti/davinci_cpdma.h
@@ -81,6 +81,7 @@ int cpdma_ctlr_dump(struct cpdma_ctlr *ctlr);
struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num,
cpdma_handler_fn handler);
+int cpdma_chan_get_rx_buf_num(struct cpdma_ctlr *ctlr);
int cpdma_chan_destroy(struct cpdma_chan *chan);
int cpdma_chan_start(struct cpdma_chan *chan);
int cpdma_chan_stop(struct cpdma_chan *chan);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3 2/2] Documentation: DT: cpsw: remove rx_descs property
2016-06-17 10:25 [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property Ivan Khoronzhuk
2016-06-17 10:25 ` [PATCH v3 1/2] net: ethernet: ti: cpsw: remove " Ivan Khoronzhuk
@ 2016-06-17 10:25 ` Ivan Khoronzhuk
2016-06-17 15:08 ` [PATCH v3 0/2] net: ethernet: ti: cpsw: delete " Mugunthan V N
2016-06-18 4:28 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Ivan Khoronzhuk @ 2016-06-17 10:25 UTC (permalink / raw)
To: mugunthanvnm, linux-kernel
Cc: grygorii.strashko, linux-omap, netdev, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, bcousson, tony, devicetree,
Ivan Khoronzhuk
There is no reason to hold s/w dependent parameter in device tree.
Even more, there is no reason in this parameter because davinici_cpdma
driver splits pool of descriptors equally between tx and rx channels
anyway.
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Documentation/devicetree/bindings/net/cpsw.txt | 1 -
arch/arm/boot/dts/am33xx.dtsi | 1 -
arch/arm/boot/dts/am4372.dtsi | 1 -
arch/arm/boot/dts/dm814x.dtsi | 1 -
arch/arm/boot/dts/dra7.dtsi | 1 -
5 files changed, 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt
index 0ae0649..5ad439f 100644
--- a/Documentation/devicetree/bindings/net/cpsw.txt
+++ b/Documentation/devicetree/bindings/net/cpsw.txt
@@ -15,7 +15,6 @@ Required properties:
- cpdma_channels : Specifies number of channels in CPDMA
- ale_entries : Specifies No of entries ALE can hold
- bd_ram_size : Specifies internal descriptor RAM size
-- rx_descs : Specifies number of Rx descriptors
- mac_control : Specifies Default MAC control register content
for the specific platform
- slaves : Specifies number for slaves
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 52be48b..702126f 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -766,7 +766,6 @@
ale_entries = <1024>;
bd_ram_size = <0x2000>;
no_bd_ram = <0>;
- rx_descs = <64>;
mac_control = <0x20>;
slaves = <2>;
active_slave = <0>;
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 12fcde4..a10fa7f 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -626,7 +626,6 @@
ale_entries = <1024>;
bd_ram_size = <0x2000>;
no_bd_ram = <0>;
- rx_descs = <64>;
mac_control = <0x20>;
slaves = <2>;
active_slave = <0>;
diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/boot/dts/dm814x.dtsi
index d4537dc..f23cae0c 100644
--- a/arch/arm/boot/dts/dm814x.dtsi
+++ b/arch/arm/boot/dts/dm814x.dtsi
@@ -509,7 +509,6 @@
ale_entries = <1024>;
bd_ram_size = <0x2000>;
no_bd_ram = <0>;
- rx_descs = <64>;
mac_control = <0x20>;
slaves = <2>;
active_slave = <0>;
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index e007401..b7ddc64 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1626,7 +1626,6 @@
ale_entries = <1024>;
bd_ram_size = <0x2000>;
no_bd_ram = <0>;
- rx_descs = <64>;
mac_control = <0x20>;
slaves = <2>;
active_slave = <0>;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property
2016-06-17 10:25 [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property Ivan Khoronzhuk
2016-06-17 10:25 ` [PATCH v3 1/2] net: ethernet: ti: cpsw: remove " Ivan Khoronzhuk
2016-06-17 10:25 ` [PATCH v3 2/2] Documentation: DT: " Ivan Khoronzhuk
@ 2016-06-17 15:08 ` Mugunthan V N
2016-06-18 4:28 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Mugunthan V N @ 2016-06-17 15:08 UTC (permalink / raw)
To: Ivan Khoronzhuk, linux-kernel
Cc: grygorii.strashko, linux-omap, netdev, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, bcousson, tony, devicetree
On Friday 17 June 2016 03:55 PM, Ivan Khoronzhuk wrote:
> There is no reason in rx_descs property because davinici_cpdma
> driver splits pool of descriptors equally between tx and rx channels.
> So, this patch series makes driver to use available number of
> descriptors for rx channels.
>
> Based on
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> master
>
> Since v2:
> - add declaration of buf_num in correct order
>
> Since v1:
> - separate device tree and driver patches
> - return number of rx buffers from cpdma driver
>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property
2016-06-17 10:25 [PATCH v3 0/2] net: ethernet: ti: cpsw: delete rx_descs property Ivan Khoronzhuk
` (2 preceding siblings ...)
2016-06-17 15:08 ` [PATCH v3 0/2] net: ethernet: ti: cpsw: delete " Mugunthan V N
@ 2016-06-18 4:28 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-06-18 4:28 UTC (permalink / raw)
To: ivan.khoronzhuk
Cc: mugunthanvnm, linux-kernel, grygorii.strashko, linux-omap, netdev,
robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
bcousson, tony, devicetree
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Fri, 17 Jun 2016 13:25:38 +0300
> There is no reason in rx_descs property because davinici_cpdma
> driver splits pool of descriptors equally between tx and rx channels.
> So, this patch series makes driver to use available number of
> descriptors for rx channels.
>
> Based on
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> master
>
> Since v2:
> - add declaration of buf_num in correct order
Series applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread