From: Tero Kristo <t-kristo@ti.com>
To: linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org,
tony@atomide.com, herbert@gondor.apana.org.au,
davem@davemloft.net, lokeshvutla@ti.com
Cc: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 04/27] crypto: omap-sham: set sw fallback to 240 bytes
Date: Wed, 22 Jun 2016 16:23:37 +0300 [thread overview]
Message-ID: <1466601840-18486-5-git-send-email-t-kristo@ti.com> (raw)
In-Reply-To: <1466601840-18486-1-git-send-email-t-kristo@ti.com>
From: Bin Liu <b-liu@ti.com>
Adds software fallback support for small crypto requests. In these cases,
it is undesirable to use DMA, as setting it up itself is rather heavy
operation. Gives about 40% extra performance in ipsec usecase.
Signed-off-by: Bin Liu <b-liu@ti.com>
[t-kristo@ti.com: dropped the extra traces, updated some comments
on the code]
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
drivers/crypto/omap-sham.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index fd3cac3..6247887 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -1095,7 +1095,7 @@ static int omap_sham_update(struct ahash_request *req)
ctx->offset = 0;
if (ctx->flags & BIT(FLAGS_FINUP)) {
- if ((ctx->digcnt + ctx->bufcnt + ctx->total) < 9) {
+ if ((ctx->digcnt + ctx->bufcnt + ctx->total) < 240) {
/*
* OMAP HW accel works only with buffers >= 9
* will switch to bypass in final()
@@ -1151,9 +1151,13 @@ static int omap_sham_final(struct ahash_request *req)
if (ctx->flags & BIT(FLAGS_ERROR))
return 0; /* uncompleted hash is not needed */
- /* OMAP HW accel works only with buffers >= 9 */
- /* HMAC is always >= 9 because ipad == block size */
- if ((ctx->digcnt + ctx->bufcnt) < 9)
+ /*
+ * OMAP HW accel works only with buffers >= 9.
+ * HMAC is always >= 9 because ipad == block size.
+ * If buffersize is less than 240, we use fallback SW encoding,
+ * as using DMA + HW in this case doesn't provide any benefit.
+ */
+ if ((ctx->digcnt + ctx->bufcnt) < 240)
return omap_sham_final_shash(req);
else if (ctx->bufcnt)
return omap_sham_enqueue(req, OP_FINAL);
--
1.9.1
next prev parent reply other threads:[~2016-06-22 13:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 13:23 [PATCHv2 00/27] crypto: fixes for omap family of devices Tero Kristo
2016-06-22 13:23 ` [PATCHv2 01/27] crypto: omap-sham: use runtime_pm autosuspend for clock handling Tero Kristo
2016-06-24 13:30 ` Herbert Xu
2016-06-22 13:23 ` [PATCHv2 02/27] crypto: omap-sham: change queue size from 1 to 10 Tero Kristo
2016-06-22 13:23 ` [PATCHv2 03/27] crypto: omap: do not call dmaengine_terminate_all Tero Kristo
2016-06-22 13:23 ` Tero Kristo [this message]
2016-06-22 13:23 ` [PATCHv2 05/27] crypto: omap-sham: avoid executing tasklet where not needed Tero Kristo
2016-06-24 10:30 ` Herbert Xu
2016-06-27 5:04 ` Tero Kristo
2016-06-22 13:23 ` [PATCHv2 06/27] crypto: ahash: increase the maximum allowed statesize Tero Kristo
2016-06-24 10:32 ` Herbert Xu
2016-06-27 4:58 ` Tero Kristo
2016-06-27 5:00 ` Herbert Xu
2016-07-04 9:17 ` Tero Kristo
2016-07-04 9:19 ` Herbert Xu
2016-07-04 9:27 ` Tero Kristo
2016-07-04 9:42 ` Herbert Xu
2016-06-22 13:23 ` [PATCHv2 07/27] crypto: omap-sham: implement context export/import APIs Tero Kristo
2016-06-22 13:23 ` [PATCHv2 08/27] crypto: omap-des: Fix support for unequal lengths Tero Kristo
2016-06-22 13:23 ` [PATCHv2 09/27] crypto: omap-aes - Fix enabling clocks Tero Kristo
2016-06-22 13:23 ` [PATCHv2 10/27] crypto: omap-aes: Add support for multiple cores Tero Kristo
2016-06-22 13:23 ` [PATCHv2 11/27] crypto: omap-aes: Add fallback support Tero Kristo
2016-06-22 13:23 ` [PATCHv2 12/27] crypto: engine: avoid unnecessary context switches Tero Kristo
2016-06-22 13:23 ` [PATCHv2 13/27] crypto: omap-aes: fix crypto engine initialization order Tero Kristo
2016-06-22 13:23 ` [PATCHv2 14/27] crypto: omap-des: " Tero Kristo
2016-06-22 13:23 ` [PATCHv2 15/27] ARM: dts: DRA7: Add DT node for DES IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 16/27] ARM: dts: DRA7: Add DT nodes for AES IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 17/27] ARM: dts: DRA7: Add support for SHA IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 18/27] ARM: dts: DRA7: Add DT node for RNG IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 19/27] ARM: dts: AM43xx: clk: Add RNG clk node Tero Kristo
2016-06-22 13:23 ` [PATCHv2 20/27] ARM: dts: AM43xx: Add node for RNG Tero Kristo
2016-06-22 13:23 ` [PATCHv2 21/27] ARM: DRA7: hwmod: Add data for DES IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 22/27] ARM: DRA7: hwmod: Add data for AES IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 23/27] ARM: DRA7: hwmod: Add data for SHA IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 24/27] ARM: DRA7: hwmod: Add data for RNG IP Tero Kristo
2016-06-22 13:23 ` [PATCHv2 25/27] ARM: OMAP: DRA7xx: Make L4SEC clock domain SWSUP only Tero Kristo
2016-06-22 13:23 ` [PATCHv2 26/27] ARM: AM43xx: hwmod: Add data for DES Tero Kristo
2016-06-22 13:24 ` [PATCHv2 27/27] ARM: AMx3xx: hwmod: Add data for RNG Tero Kristo
2016-06-23 4:49 ` [PATCHv2 00/27] crypto: fixes for omap family of devices Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466601840-18486-5-git-send-email-t-kristo@ti.com \
--to=t-kristo@ti.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).