[PATCH 00/35 linux-next] constify of_device_id array

[PATCH 00/35 linux-next] constify of_device_id array

[Fabian Frederick]

This small patchset adds const to of_device_id arrays in
drivers branch.

Fabian Frederick (35):
  ata: constify of_device_id array
  regulator: constify of_device_id array
  thermal: constify of_device_id array
  tty/hvc_opal: constify of_device_id array
  tty: constify of_device_id array
  power: constify of_device_id array
  char: constify of_device_id array
  dma: constify of_device_id array
  iio: constify of_device_id array
  misc: constify of_device_id array
  usb: gadget: constify of_device_id array
  mtd: constify of_device_id array
  w1: constify of_device_id array
  ide: pmac: constify of_device_id array
  spi: constify of_device_id array
  video: constify of_device_id array
  coresight-replicator: constify of_device_id array
  macintosh: constify of_device_id array
  virtio_mmio: constify of_device_id array
  swim3: constify of_device_id array
  mfd: constify of_device_id array
  soc: ti: constify of_device_id array
  [media]: constify of_device_id array
  Input: constify of_device_id array
  PCI: constify of_device_id array
  hwmon: constify of_device_id array
  reset: sti: constify of_device_id array
  uio: constify of_device_id array
  gpu: constify of_device_id array
  devfreq: constify of_device_id array
  EDAC: constify of_device_id array
  clk: constify of_device_id array
  mmc: constify of_device_id array
  Staging: octeon: constify of_device_id array
  pinctrl: constify of_device_id array

 drivers/ata/pata_macio.c                     | 2 +-
 drivers/ata/pata_mpc52xx.c                   | 2 +-
 drivers/ata/pata_octeon_cf.c                 | 2 +-
 drivers/ata/pata_of_platform.c               | 2 +-
 drivers/ata/sata_fsl.c                       | 2 +-
 drivers/ata/sata_mv.c                        | 2 +-
 drivers/ata/sata_rcar.c                      | 2 +-
 drivers/block/swim3.c                        | 2 +-
 drivers/char/hw_random/pasemi-rng.c          | 2 +-
 drivers/char/hw_random/powernv-rng.c         | 2 +-
 drivers/char/hw_random/ppc4xx-rng.c          | 2 +-
 drivers/char/ipmi/ipmi_si_intf.c             | 4 ++--
 drivers/char/xillybus/xillybus_of.c          | 2 +-
 drivers/clk/clk-palmas.c                     | 2 +-
 drivers/clk/st/clkgen-fsyn.c                 | 2 +-
 drivers/clk/st/clkgen-mux.c                  | 8 ++++----
 drivers/clk/st/clkgen-pll.c                  | 4 ++--
 drivers/clk/ti/clk-dra7-atl.c                | 2 +-
 drivers/clk/ti/clockdomain.c                 | 2 +-
 drivers/clk/versatile/clk-vexpress-osc.c     | 2 +-
 drivers/coresight/coresight-replicator.c     | 2 +-
 drivers/devfreq/event/exynos-ppmu.c          | 2 +-
 drivers/devfreq/tegra-devfreq.c              | 2 +-
 drivers/dma/bestcomm/bestcomm.c              | 4 ++--
 drivers/dma/k3dma.c                          | 2 +-
 drivers/dma/mmp_pdma.c                       | 2 +-
 drivers/dma/mmp_tdma.c                       | 2 +-
 drivers/dma/mpc512x_dma.c                    | 2 +-
 drivers/dma/mv_xor.c                         | 2 +-
 drivers/dma/sirf-dma.c                       | 2 +-
 drivers/dma/sun6i-dma.c                      | 2 +-
 drivers/edac/highbank_mc_edac.c              | 2 +-
 drivers/edac/mpc85xx_edac.c                  | 4 ++--
 drivers/edac/ppc4xx_edac.c                   | 2 +-
 drivers/edac/synopsys_edac.c                 | 2 +-
 drivers/gpio/gpio-mpc8xxx.c                  | 2 +-
 drivers/gpio/gpio-octeon.c                   | 2 +-
 drivers/gpio/gpio-tz1090-pdc.c               | 2 +-
 drivers/gpio/gpio-tz1090.c                   | 2 +-
 drivers/gpio/gpio-zynq.c                     | 2 +-
 drivers/gpu/drm/armada/armada_crtc.c         | 2 +-
 drivers/gpu/drm/exynos/exynos_drm_dsi.c      | 2 +-
 drivers/gpu/drm/exynos/exynos_hdmi.c         | 2 +-
 drivers/gpu/drm/exynos/exynos_mixer.c        | 2 +-
 drivers/gpu/drm/panel/panel-ld9040.c         | 2 +-
 drivers/gpu/drm/panel/panel-s6e8aa0.c        | 2 +-
 drivers/gpu/drm/sti/sti_dvo.c                | 2 +-
 drivers/gpu/drm/sti/sti_hqvdp.c              | 2 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c          | 4 ++--
 drivers/gpu/drm/tilcdc/tilcdc_panel.c        | 2 +-
 drivers/gpu/drm/tilcdc/tilcdc_slave.c        | 4 ++--
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c       | 4 ++--
 drivers/gpu/host1x/dev.c                     | 2 +-
 drivers/gpu/host1x/mipi.c                    | 2 +-
 drivers/hwmon/pwm-fan.c                      | 2 +-
 drivers/hwmon/vexpress.c                     | 2 +-
 drivers/ide/pmac.c                           | 2 +-
 drivers/iio/common/ssp_sensors/ssp_dev.c     | 2 +-
 drivers/input/misc/palmas-pwrbutton.c        | 2 +-
 drivers/input/misc/regulator-haptic.c        | 2 +-
 drivers/input/misc/tps65218-pwrbutton.c      | 2 +-
 drivers/input/touchscreen/ar1021_i2c.c       | 2 +-
 drivers/macintosh/mediabay.c                 | 2 +-
 drivers/macintosh/rack-meter.c               | 2 +-
 drivers/media/i2c/adv7604.c                  | 2 +-
 drivers/media/platform/fsl-viu.c             | 2 +-
 drivers/media/platform/soc_camera/rcar_vin.c | 2 +-
 drivers/media/rc/gpio-ir-recv.c              | 2 +-
 drivers/media/rc/ir-hix5hd2.c                | 2 +-
 drivers/media/rc/st_rc.c                     | 2 +-
 drivers/mfd/hi6421-pmic-core.c               | 2 +-
 drivers/mfd/rk808.c                          | 2 +-
 drivers/mfd/twl4030-power.c                  | 2 +-
 drivers/misc/carma/carma-fpga-program.c      | 2 +-
 drivers/misc/carma/carma-fpga.c              | 2 +-
 drivers/misc/lis3lv02d/lis3lv02d_i2c.c       | 2 +-
 drivers/misc/lis3lv02d/lis3lv02d_spi.c       | 2 +-
 drivers/misc/sram.c                          | 2 +-
 drivers/mmc/host/mmc_spi.c                   | 2 +-
 drivers/mmc/host/wmt-sdmmc.c                 | 2 +-
 drivers/mtd/devices/docg3.c                  | 2 +-
 drivers/mtd/maps/physmap_of.c                | 4 ++--
 drivers/mtd/nand/mpc5121_nfc.c               | 2 +-
 drivers/mtd/spi-nor/fsl-quadspi.c            | 2 +-
 drivers/pci/host/pci-rcar-gen2.c             | 2 +-
 drivers/pci/host/pcie-xilinx.c               | 2 +-
 drivers/pinctrl/bcm/pinctrl-bcm2835.c        | 2 +-
 drivers/pinctrl/mediatek/pinctrl-mt8135.c    | 2 +-
 drivers/pinctrl/mediatek/pinctrl-mt8173.c    | 2 +-
 drivers/pinctrl/mvebu/pinctrl-armada-370.c   | 2 +-
 drivers/pinctrl/mvebu/pinctrl-armada-375.c   | 2 +-
 drivers/pinctrl/mvebu/pinctrl-armada-38x.c   | 2 +-
 drivers/pinctrl/mvebu/pinctrl-armada-39x.c   | 2 +-
 drivers/pinctrl/mvebu/pinctrl-armada-xp.c    | 2 +-
 drivers/pinctrl/mvebu/pinctrl-kirkwood.c     | 2 +-
 drivers/pinctrl/mvebu/pinctrl-orion.c        | 2 +-
 drivers/pinctrl/pinctrl-as3722.c             | 2 +-
 drivers/pinctrl/pinctrl-at91.c               | 4 ++--
 drivers/pinctrl/pinctrl-palmas.c             | 2 +-
 drivers/pinctrl/pinctrl-single.c             | 4 ++--
 drivers/pinctrl/pinctrl-st.c                 | 2 +-
 drivers/pinctrl/pinctrl-tz1090-pdc.c         | 2 +-
 drivers/pinctrl/pinctrl-tz1090.c             | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c    | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun5i-a10s.c   | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun5i-a13.c    | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c  | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun6i-a31.c    | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun6i-a31s.c   | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c    | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c  | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun8i-a23.c    | 2 +-
 drivers/pinctrl/sunxi/pinctrl-sun9i-a80.c    | 2 +-
 drivers/pinctrl/vt8500/pinctrl-vt8500.c      | 2 +-
 drivers/pinctrl/vt8500/pinctrl-wm8505.c      | 2 +-
 drivers/pinctrl/vt8500/pinctrl-wm8650.c      | 2 +-
 drivers/pinctrl/vt8500/pinctrl-wm8750.c      | 2 +-
 drivers/pinctrl/vt8500/pinctrl-wm8850.c      | 2 +-
 drivers/power/charger-manager.c              | 2 +-
 drivers/power/reset/at91-poweroff.c          | 2 +-
 drivers/power/reset/at91-reset.c             | 4 ++--
 drivers/power/reset/hisi-reboot.c            | 2 +-
 drivers/power/reset/keystone-reset.c         | 2 +-
 drivers/power/reset/st-poweroff.c            | 2 +-
 drivers/power/reset/syscon-reboot.c          | 2 +-
 drivers/power/reset/vexpress-poweroff.c      | 2 +-
 drivers/power/reset/xgene-reboot.c           | 2 +-
 drivers/power/tps65090-charger.c             | 2 +-
 drivers/regulator/palmas-regulator.c         | 2 +-
 drivers/reset/sti/reset-stih407.c            | 2 +-
 drivers/reset/sti/reset-stih415.c            | 2 +-
 drivers/reset/sti/reset-stih416.c            | 2 +-
 drivers/soc/ti/knav_dma.c                    | 2 +-
 drivers/soc/ti/knav_qmss_queue.c             | 2 +-
 drivers/spi/spi-mpc512x-psc.c                | 2 +-
 drivers/spi/spi-octeon.c                     | 2 +-
 drivers/spi/spi-st-ssc4.c                    | 2 +-
 drivers/staging/octeon-usb/octeon-hcd.c      | 2 +-
 drivers/staging/octeon/ethernet.c            | 2 +-
 drivers/thermal/st/st_thermal_memmap.c       | 2 +-
 drivers/thermal/st/st_thermal_syscfg.c       | 2 +-
 drivers/tty/hvc/hvc_opal.c                   | 2 +-
 drivers/tty/serial/apbuart.c                 | 2 +-
 drivers/tty/serial/cpm_uart/cpm_uart_core.c  | 2 +-
 drivers/tty/serial/fsl_lpuart.c              | 2 +-
 drivers/tty/serial/mpc52xx_uart.c            | 2 +-
 drivers/tty/serial/mxs-auart.c               | 2 +-
 drivers/tty/serial/of_serial.c               | 4 ++--
 drivers/tty/serial/pmac_zilog.c              | 2 +-
 drivers/tty/serial/pxa.c                     | 2 +-
 drivers/tty/serial/serial-tegra.c            | 2 +-
 drivers/tty/serial/sirfsoc_uart.c            | 2 +-
 drivers/tty/serial/st-asc.c                  | 2 +-
 drivers/tty/serial/uartlite.c                | 2 +-
 drivers/tty/serial/ucc_uart.c                | 2 +-
 drivers/tty/serial/xilinx_uartps.c           | 2 +-
 drivers/uio/uio_pdrv_genirq.c                | 2 +-
 drivers/usb/gadget/udc/pxa27x_udc.c          | 2 +-
 drivers/video/backlight/gpio_backlight.c     | 2 +-
 drivers/video/backlight/pwm_bl.c             | 2 +-
 drivers/video/fbdev/fsl-diu-fb.c             | 2 +-
 drivers/video/fbdev/grvga.c                  | 2 +-
 drivers/video/fbdev/mb862xx/mb862xxfbdrv.c   | 2 +-
 drivers/video/fbdev/ocfb.c                   | 2 +-
 drivers/video/fbdev/platinumfb.c             | 2 +-
 drivers/video/fbdev/xilinxfb.c               | 2 +-
 drivers/virtio/virtio_mmio.c                 | 2 +-
 drivers/w1/masters/mxc_w1.c                  | 2 +-
 drivers/w1/masters/omap_hdq.c                | 2 +-
 drivers/w1/masters/w1-gpio.c                 | 2 +-
 170 files changed, 185 insertions(+), 185 deletions(-)

-- 
2.1.0

[PATCH 02/35 linux-next] regulator: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/regulator/palmas-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 9205f43..eecce1e 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -1505,7 +1505,7 @@ static void palmas_dt_to_pdata(struct device *dev,
 	pdata->ldo6_vibrator = of_property_read_bool(node, "ti,ldo6-vibrator");
 }
 
-static struct of_device_id of_palmas_match_tbl[] = {
+static const struct of_device_id of_palmas_match_tbl[] = {
 	{
 		.compatible = "ti,palmas-pmic",
 		.data = &palmas_ddata,
-- 
2.1.0

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Mon, Mar 16, 2015 at 08:17:08PM +0100, Fabian Frederick wrote:
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)

Applied, thanks.  Please remember to always include people in the cover
letter for patch serieses so they know what's going on with regard to
dependencies and so on.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Fabian Frederick]

> On 17 March 2015 at 13:11 Mark Brown <broonie@kernel.org> wrote:
>
>
> On Mon, Mar 16, 2015 at 08:17:08PM +0100, Fabian Frederick wrote:
> > of_device_id is always used as const.
> > (See driver.of_match_table and open firmware functions)
>
> Applied, thanks.  Please remember to always include people in the cover
> letter for patch serieses so they know what's going on with regard to
> dependencies and so on.

Thanks Mark, I used a --cc-cmd script by Joe Perches with
git send-email which uses --nom for cover-letter.

This limits recipients to mailing lists: 37 instead of 123 in this case.
I guess it's better to reduce the noise :)

Regards,
Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

On Tue, Mar 17, 2015 at 06:10:12PM +0100, Fabian Frederick wrote:

> Thanks Mark, I used a --cc-cmd script by Joe Perches with
> git send-email which uses --nom for cover-letter.

> This limits recipients to mailing lists: 37 instead of 123 in this case.
> I guess it's better to reduce the noise :)

Well, another thing to do if there's no dependencies is to just send
each patch separately - there's no real relationship between the
patches.  This also avoids the issue.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Fabian Frederick]

> On 17 March 2015 at 18:19 Mark Brown <broonie@kernel.org> wrote:
>
>
> On Tue, Mar 17, 2015 at 06:10:12PM +0100, Fabian Frederick wrote:
>
> > Thanks Mark, I used a --cc-cmd script by Joe Perches with
> > git send-email which uses --nom for cover-letter.
>
> > This limits recipients to mailing lists: 37 instead of 123 in this case.
> > I guess it's better to reduce the noise :)
>
> Well, another thing to do if there's no dependencies is to just send
> each patch separately - there's no real relationship between the
> patches.  This also avoids the issue.

Such trivial updates are generally applied by David or Greg
after receiving some ack. That's the reason for the patchset :)

Re: [PATCH 02/35 linux-next] regulator: constify of_device_id array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

On Tue, Mar 17, 2015 at 06:26:17PM +0100, Fabian Frederick wrote:
> > On 17 March 2015 at 18:19 Mark Brown <broonie@kernel.org> wrote:

> > Well, another thing to do if there's no dependencies is to just send
> > each patch separately - there's no real relationship between the
> > patches.  This also avoids the issue.

> Such trivial updates are generally applied by David or Greg
> after receiving some ack. That's the reason for the patchset :)

It's pretty disappointing if that's the case, though it might be
something connected with the submission style - for most of the kernel
patches would normally be handled directly by the maintainer.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[PATCH 21/35 linux-next] mfd: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/mfd/hi6421-pmic-core.c | 2 +-
 drivers/mfd/rk808.c            | 2 +-
 drivers/mfd/twl4030-power.c    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
index 7210ae2..95b2ff8 100644
--- a/drivers/mfd/hi6421-pmic-core.c
+++ b/drivers/mfd/hi6421-pmic-core.c
@@ -93,7 +93,7 @@ static int hi6421_pmic_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct of_device_id of_hi6421_pmic_match_tbl[] = {
+static const struct of_device_id of_hi6421_pmic_match_tbl[] = {
 	{ .compatible = "hisilicon,hi6421-pmic", },
 	{ },
 };
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index 7cf25c7..4b1e439 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -246,7 +246,7 @@ static int rk808_remove(struct i2c_client *client)
 	return 0;
 }
 
-static struct of_device_id rk808_of_match[] = {
+static const struct of_device_id rk808_of_match[] = {
 	{ .compatible = "rockchip,rk808" },
 	{ },
 };
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 3935092..f440aed 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -829,7 +829,7 @@ static struct twl4030_power_data osc_off_idle = {
 	.board_config		= osc_off_rconfig,
 };
 
-static struct of_device_id twl4030_power_of_match[] = {
+static const struct of_device_id twl4030_power_of_match[] = {
 	{
 		.compatible = "ti,twl4030-power",
 	},
-- 
2.1.0

Re: [PATCH 21/35 linux-next] mfd: constify of_device_id array

[Lee Jones]

On Mon, 16 Mar 2015, Fabian Frederick wrote:

> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  drivers/mfd/hi6421-pmic-core.c | 2 +-
>  drivers/mfd/rk808.c            | 2 +-
>  drivers/mfd/twl4030-power.c    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
> index 7210ae2..95b2ff8 100644
> --- a/drivers/mfd/hi6421-pmic-core.c
> +++ b/drivers/mfd/hi6421-pmic-core.c
> @@ -93,7 +93,7 @@ static int hi6421_pmic_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct of_device_id of_hi6421_pmic_match_tbl[] = {
> +static const struct of_device_id of_hi6421_pmic_match_tbl[] = {
>  	{ .compatible = "hisilicon,hi6421-pmic", },
>  	{ },
>  };
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index 7cf25c7..4b1e439 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -246,7 +246,7 @@ static int rk808_remove(struct i2c_client *client)
>  	return 0;
>  }
>  
> -static struct of_device_id rk808_of_match[] = {
> +static const struct of_device_id rk808_of_match[] = {
>  	{ .compatible = "rockchip,rk808" },
>  	{ },
>  };
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 3935092..f440aed 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -829,7 +829,7 @@ static struct twl4030_power_data osc_off_idle = {
>  	.board_config		= osc_off_rconfig,
>  };
>  
> -static struct of_device_id twl4030_power_of_match[] = {
> +static const struct of_device_id twl4030_power_of_match[] = {
>  	{
>  		.compatible = "ti,twl4030-power",
>  	},

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH 32/35 linux-next] clk: constify of_device_id array

[Fabian Frederick]

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/clk/clk-palmas.c                 | 2 +-
 drivers/clk/st/clkgen-fsyn.c             | 2 +-
 drivers/clk/st/clkgen-mux.c              | 8 ++++----
 drivers/clk/st/clkgen-pll.c              | 4 ++--
 drivers/clk/ti/clk-dra7-atl.c            | 2 +-
 drivers/clk/ti/clockdomain.c             | 2 +-
 drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
index 8d45992..45a535a 100644
--- a/drivers/clk/clk-palmas.c
+++ b/drivers/clk/clk-palmas.c
@@ -161,7 +161,7 @@ static struct palmas_clks_of_match_data palmas_of_clk32kgaudio = {
 	},
 };
 
-static struct of_device_id palmas_clks_of_match[] = {
+static const struct of_device_id palmas_clks_of_match[] = {
 	{
 		.compatible = "ti,palmas-clk32kg",
 		.data = &palmas_of_clk32kg,
diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
index af94ed8..a917c4c 100644
--- a/drivers/clk/st/clkgen-fsyn.c
+++ b/drivers/clk/st/clkgen-fsyn.c
@@ -1057,7 +1057,7 @@ static struct clk * __init st_clk_register_quadfs_fsynth(
 	return clk;
 }
 
-static struct of_device_id quadfs_of_match[] = {
+static const struct of_device_id quadfs_of_match[] = {
 	{
 		.compatible = "st,stih416-quadfs216",
 		.data = &st_fs216c65_416
diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
index 9a15ec3..fdcff10 100644
--- a/drivers/clk/st/clkgen-mux.c
+++ b/drivers/clk/st/clkgen-mux.c
@@ -341,7 +341,7 @@ static struct clkgena_divmux_data st_divmux_c32odf3 = {
 	.fb_start_bit_idx = 24,
 };
 
-static struct of_device_id clkgena_divmux_of_match[] = {
+static const struct of_device_id clkgena_divmux_of_match[] = {
 	{
 		.compatible = "st,clkgena-divmux-c65-hs",
 		.data = &st_divmux_c65hs,
@@ -479,7 +479,7 @@ static struct clkgena_prediv_data prediv_c32_data = {
 	.table = prediv_table16,
 };
 
-static struct of_device_id clkgena_prediv_of_match[] = {
+static const struct of_device_id clkgena_prediv_of_match[] = {
 	{ .compatible = "st,clkgena-prediv-c65", .data = &prediv_c65_data },
 	{ .compatible = "st,clkgena-prediv-c32", .data = &prediv_c32_data },
 	{}
@@ -586,7 +586,7 @@ static struct clkgen_mux_data stih407_a9_mux_data = {
 	.width = 2,
 };
 
-static struct of_device_id mux_of_match[] = {
+static const struct of_device_id mux_of_match[] = {
 	{
 		.compatible = "st,stih416-clkgenc-vcc-hd",
 		.data = &clkgen_mux_c_vcc_hd_416,
@@ -693,7 +693,7 @@ static struct clkgen_vcc_data st_clkgenf_vcc_416 = {
 	.lock = &clkgenf_lock,
 };
 
-static struct of_device_id vcc_of_match[] = {
+static const struct of_device_id vcc_of_match[] = {
 	{ .compatible = "st,stih416-clkgenc", .data = &st_clkgenc_vcc_416 },
 	{ .compatible = "st,stih416-clkgenf", .data = &st_clkgenf_vcc_416 },
 	{}
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index 29769d7..d204ba8 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -593,7 +593,7 @@ static struct clk * __init clkgen_odf_register(const char *parent_name,
 	return clk;
 }
 
-static struct of_device_id c32_pll_of_match[] = {
+static const struct of_device_id c32_pll_of_match[] = {
 	{
 		.compatible = "st,plls-c32-a1x-0",
 		.data = &st_pll3200c32_a1x_0,
@@ -708,7 +708,7 @@ err:
 }
 CLK_OF_DECLARE(clkgen_c32_pll, "st,clkgen-plls-c32", clkgen_c32_pll_setup);
 
-static struct of_device_id c32_gpu_pll_of_match[] = {
+static const struct of_device_id c32_gpu_pll_of_match[] = {
 	{
 		.compatible = "st,stih415-gpu-pll-c32",
 		.data = &st_pll1200c32_gpu_415,
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 59bb4b3..d86bc46 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -294,7 +294,7 @@ static int of_dra7_atl_clk_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct of_device_id of_dra7_atl_clk_match_tbl[] = {
+static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
 	{ .compatible = "ti,dra7-atl", },
 	{},
 };
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
index b4c5fac..35fe108 100644
--- a/drivers/clk/ti/clockdomain.c
+++ b/drivers/clk/ti/clockdomain.c
@@ -52,7 +52,7 @@ static void __init of_ti_clockdomain_setup(struct device_node *node)
 	}
 }
 
-static struct of_device_id ti_clkdm_match_table[] __initdata = {
+static const struct of_device_id ti_clkdm_match_table[] __initconst = {
 	{ .compatible = "ti,clockdomain" },
 	{ }
 };
diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
index 765f1e0..89c0609 100644
--- a/drivers/clk/versatile/clk-vexpress-osc.c
+++ b/drivers/clk/versatile/clk-vexpress-osc.c
@@ -110,7 +110,7 @@ static int vexpress_osc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static struct of_device_id vexpress_osc_of_match[] = {
+static const struct of_device_id vexpress_osc_of_match[] = {
 	{ .compatible = "arm,vexpress-osc", },
 	{}
 };
-- 
2.1.0

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

[Michael Turquette]

Quoting Fabian Frederick (2015-03-16 12:59:06)
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Acked-by: Michael Turquette <mturquette@linaro.org>

> ---
>  drivers/clk/clk-palmas.c                 | 2 +-
>  drivers/clk/st/clkgen-fsyn.c             | 2 +-
>  drivers/clk/st/clkgen-mux.c              | 8 ++++----
>  drivers/clk/st/clkgen-pll.c              | 4 ++--
>  drivers/clk/ti/clk-dra7-atl.c            | 2 +-
>  drivers/clk/ti/clockdomain.c             | 2 +-
>  drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
>  7 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
> index 8d45992..45a535a 100644
> --- a/drivers/clk/clk-palmas.c
> +++ b/drivers/clk/clk-palmas.c
> @@ -161,7 +161,7 @@ static struct palmas_clks_of_match_data palmas_of_clk32kgaudio = {
>         },
>  };
>  
> -static struct of_device_id palmas_clks_of_match[] = {
> +static const struct of_device_id palmas_clks_of_match[] = {
>         {
>                 .compatible = "ti,palmas-clk32kg",
>                 .data = &palmas_of_clk32kg,
> diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
> index af94ed8..a917c4c 100644
> --- a/drivers/clk/st/clkgen-fsyn.c
> +++ b/drivers/clk/st/clkgen-fsyn.c
> @@ -1057,7 +1057,7 @@ static struct clk * __init st_clk_register_quadfs_fsynth(
>         return clk;
>  }
>  
> -static struct of_device_id quadfs_of_match[] = {
> +static const struct of_device_id quadfs_of_match[] = {
>         {
>                 .compatible = "st,stih416-quadfs216",
>                 .data = &st_fs216c65_416
> diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
> index 9a15ec3..fdcff10 100644
> --- a/drivers/clk/st/clkgen-mux.c
> +++ b/drivers/clk/st/clkgen-mux.c
> @@ -341,7 +341,7 @@ static struct clkgena_divmux_data st_divmux_c32odf3 = {
>         .fb_start_bit_idx = 24,
>  };
>  
> -static struct of_device_id clkgena_divmux_of_match[] = {
> +static const struct of_device_id clkgena_divmux_of_match[] = {
>         {
>                 .compatible = "st,clkgena-divmux-c65-hs",
>                 .data = &st_divmux_c65hs,
> @@ -479,7 +479,7 @@ static struct clkgena_prediv_data prediv_c32_data = {
>         .table = prediv_table16,
>  };
>  
> -static struct of_device_id clkgena_prediv_of_match[] = {
> +static const struct of_device_id clkgena_prediv_of_match[] = {
>         { .compatible = "st,clkgena-prediv-c65", .data = &prediv_c65_data },
>         { .compatible = "st,clkgena-prediv-c32", .data = &prediv_c32_data },
>         {}
> @@ -586,7 +586,7 @@ static struct clkgen_mux_data stih407_a9_mux_data = {
>         .width = 2,
>  };
>  
> -static struct of_device_id mux_of_match[] = {
> +static const struct of_device_id mux_of_match[] = {
>         {
>                 .compatible = "st,stih416-clkgenc-vcc-hd",
>                 .data = &clkgen_mux_c_vcc_hd_416,
> @@ -693,7 +693,7 @@ static struct clkgen_vcc_data st_clkgenf_vcc_416 = {
>         .lock = &clkgenf_lock,
>  };
>  
> -static struct of_device_id vcc_of_match[] = {
> +static const struct of_device_id vcc_of_match[] = {
>         { .compatible = "st,stih416-clkgenc", .data = &st_clkgenc_vcc_416 },
>         { .compatible = "st,stih416-clkgenf", .data = &st_clkgenf_vcc_416 },
>         {}
> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> index 29769d7..d204ba8 100644
> --- a/drivers/clk/st/clkgen-pll.c
> +++ b/drivers/clk/st/clkgen-pll.c
> @@ -593,7 +593,7 @@ static struct clk * __init clkgen_odf_register(const char *parent_name,
>         return clk;
>  }
>  
> -static struct of_device_id c32_pll_of_match[] = {
> +static const struct of_device_id c32_pll_of_match[] = {
>         {
>                 .compatible = "st,plls-c32-a1x-0",
>                 .data = &st_pll3200c32_a1x_0,
> @@ -708,7 +708,7 @@ err:
>  }
>  CLK_OF_DECLARE(clkgen_c32_pll, "st,clkgen-plls-c32", clkgen_c32_pll_setup);
>  
> -static struct of_device_id c32_gpu_pll_of_match[] = {
> +static const struct of_device_id c32_gpu_pll_of_match[] = {
>         {
>                 .compatible = "st,stih415-gpu-pll-c32",
>                 .data = &st_pll1200c32_gpu_415,
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index 59bb4b3..d86bc46 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -294,7 +294,7 @@ static int of_dra7_atl_clk_remove(struct platform_device *pdev)
>         return 0;
>  }
>  
> -static struct of_device_id of_dra7_atl_clk_match_tbl[] = {
> +static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
>         { .compatible = "ti,dra7-atl", },
>         {},
>  };
> diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
> index b4c5fac..35fe108 100644
> --- a/drivers/clk/ti/clockdomain.c
> +++ b/drivers/clk/ti/clockdomain.c
> @@ -52,7 +52,7 @@ static void __init of_ti_clockdomain_setup(struct device_node *node)
>         }
>  }
>  
> -static struct of_device_id ti_clkdm_match_table[] __initdata = {
> +static const struct of_device_id ti_clkdm_match_table[] __initconst = {
>         { .compatible = "ti,clockdomain" },
>         { }
>  };
> diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
> index 765f1e0..89c0609 100644
> --- a/drivers/clk/versatile/clk-vexpress-osc.c
> +++ b/drivers/clk/versatile/clk-vexpress-osc.c
> @@ -110,7 +110,7 @@ static int vexpress_osc_probe(struct platform_device *pdev)
>         return 0;
>  }
>  
> -static struct of_device_id vexpress_osc_of_match[] = {
> +static const struct of_device_id vexpress_osc_of_match[] = {
>         { .compatible = "arm,vexpress-osc", },
>         {}
>  };
> -- 
> 2.1.0
> 

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

[Fabian Frederick]

> On 18 March 2015 at 15:15 Michael Turquette <mturquette@linaro.org> wrote:
>
>
> Quoting Fabian Frederick (2015-03-16 12:59:06)
> > of_device_id is always used as const.
> > (See driver.of_match_table and open firmware functions)
> >
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> Acked-by: Michael Turquette <mturquette@linaro.org>

Thanks :)

btw, something I forgot to mention in changelog is the __initdata -> __initconst
for ti_clkdm_match_table[]

I can send it again with a new changelog if necessary ...

Regards,
Fabian

>
> > ---
> >  drivers/clk/clk-palmas.c                 | 2 +-
> >  drivers/clk/st/clkgen-fsyn.c             | 2 +-
> >  drivers/clk/st/clkgen-mux.c              | 8 ++++----
> >  drivers/clk/st/clkgen-pll.c              | 4 ++--
> >  drivers/clk/ti/clk-dra7-atl.c            | 2 +-
> >  drivers/clk/ti/clockdomain.c             | 2 +-
> >  drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
> >  7 files changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
> > index 8d45992..45a535a 100644
> > --- a/drivers/clk/clk-palmas.c
> > +++ b/drivers/clk/clk-palmas.c
> > @@ -161,7 +161,7 @@ static struct palmas_clks_of_match_data
> > palmas_of_clk32kgaudio = {
> >         },
> >  };
> > 
> > -static struct of_device_id palmas_clks_of_match[] = {
> > +static const struct of_device_id palmas_clks_of_match[] = {
> >         {
> >                 .compatible = "ti,palmas-clk32kg",
> >                 .data = &palmas_of_clk32kg,
> > diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
> > index af94ed8..a917c4c 100644
> > --- a/drivers/clk/st/clkgen-fsyn.c
> > +++ b/drivers/clk/st/clkgen-fsyn.c
> > @@ -1057,7 +1057,7 @@ static struct clk * __init
> > st_clk_register_quadfs_fsynth(
> >         return clk;
> >  }
> > 
> > -static struct of_device_id quadfs_of_match[] = {
> > +static const struct of_device_id quadfs_of_match[] = {
> >         {
> >                 .compatible = "st,stih416-quadfs216",
> >                 .data = &st_fs216c65_416
> > diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
> > index 9a15ec3..fdcff10 100644
> > --- a/drivers/clk/st/clkgen-mux.c
> > +++ b/drivers/clk/st/clkgen-mux.c
> > @@ -341,7 +341,7 @@ static struct clkgena_divmux_data st_divmux_c32odf3 = {
> >         .fb_start_bit_idx = 24,
> >  };
> > 
> > -static struct of_device_id clkgena_divmux_of_match[] = {
> > +static const struct of_device_id clkgena_divmux_of_match[] = {
> >         {
> >                 .compatible = "st,clkgena-divmux-c65-hs",
> >                 .data = &st_divmux_c65hs,
> > @@ -479,7 +479,7 @@ static struct clkgena_prediv_data prediv_c32_data = {
> >         .table = prediv_table16,
> >  };
> > 
> > -static struct of_device_id clkgena_prediv_of_match[] = {
> > +static const struct of_device_id clkgena_prediv_of_match[] = {
> >         { .compatible = "st,clkgena-prediv-c65", .data = &prediv_c65_data },
> >         { .compatible = "st,clkgena-prediv-c32", .data = &prediv_c32_data },
> >         {}
> > @@ -586,7 +586,7 @@ static struct clkgen_mux_data stih407_a9_mux_data = {
> >         .width = 2,
> >  };
> > 
> > -static struct of_device_id mux_of_match[] = {
> > +static const struct of_device_id mux_of_match[] = {
> >         {
> >                 .compatible = "st,stih416-clkgenc-vcc-hd",
> >                 .data = &clkgen_mux_c_vcc_hd_416,
> > @@ -693,7 +693,7 @@ static struct clkgen_vcc_data st_clkgenf_vcc_416 = {
> >         .lock = &clkgenf_lock,
> >  };
> > 
> > -static struct of_device_id vcc_of_match[] = {
> > +static const struct of_device_id vcc_of_match[] = {
> >         { .compatible = "st,stih416-clkgenc", .data = &st_clkgenc_vcc_416 },
> >         { .compatible = "st,stih416-clkgenf", .data = &st_clkgenf_vcc_416 },
> >         {}
> > diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> > index 29769d7..d204ba8 100644
> > --- a/drivers/clk/st/clkgen-pll.c
> > +++ b/drivers/clk/st/clkgen-pll.c
> > @@ -593,7 +593,7 @@ static struct clk * __init clkgen_odf_register(const
> > char *parent_name,
> >         return clk;
> >  }
> > 
> > -static struct of_device_id c32_pll_of_match[] = {
> > +static const struct of_device_id c32_pll_of_match[] = {
> >         {
> >                 .compatible = "st,plls-c32-a1x-0",
> >                 .data = &st_pll3200c32_a1x_0,
> > @@ -708,7 +708,7 @@ err:
> >  }
> >  CLK_OF_DECLARE(clkgen_c32_pll, "st,clkgen-plls-c32", clkgen_c32_pll_setup);
> > 
> > -static struct of_device_id c32_gpu_pll_of_match[] = {
> > +static const struct of_device_id c32_gpu_pll_of_match[] = {
> >         {
> >                 .compatible = "st,stih415-gpu-pll-c32",
> >                 .data = &st_pll1200c32_gpu_415,
> > diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> > index 59bb4b3..d86bc46 100644
> > --- a/drivers/clk/ti/clk-dra7-atl.c
> > +++ b/drivers/clk/ti/clk-dra7-atl.c
> > @@ -294,7 +294,7 @@ static int of_dra7_atl_clk_remove(struct platform_device
> > *pdev)
> >         return 0;
> >  }
> > 
> > -static struct of_device_id of_dra7_atl_clk_match_tbl[] = {
> > +static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
> >         { .compatible = "ti,dra7-atl", },
> >         {},
> >  };
> > diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
> > index b4c5fac..35fe108 100644
> > --- a/drivers/clk/ti/clockdomain.c
> > +++ b/drivers/clk/ti/clockdomain.c
> > @@ -52,7 +52,7 @@ static void __init of_ti_clockdomain_setup(struct
> > device_node *node)
> >         }
> >  }
> > 
> > -static struct of_device_id ti_clkdm_match_table[] __initdata = {
> > +static const struct of_device_id ti_clkdm_match_table[] __initconst = {
> >         { .compatible = "ti,clockdomain" },
> >         { }
> >  };
> > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c
> > b/drivers/clk/versatile/clk-vexpress-osc.c
> > index 765f1e0..89c0609 100644
> > --- a/drivers/clk/versatile/clk-vexpress-osc.c
> > +++ b/drivers/clk/versatile/clk-vexpress-osc.c
> > @@ -110,7 +110,7 @@ static int vexpress_osc_probe(struct platform_device
> > *pdev)
> >         return 0;
> >  }
> > 
> > -static struct of_device_id vexpress_osc_of_match[] = {
> > +static const struct of_device_id vexpress_osc_of_match[] = {
> >         { .compatible = "arm,vexpress-osc", },
> >         {}
> >  };
> > --
> > 2.1.0
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

[Stephen Boyd]

On 03/22, Fabian Frederick wrote:
> 
> 
> > On 18 March 2015 at 15:15 Michael Turquette <mturquette@linaro.org> wrote:
> >
> >
> > Quoting Fabian Frederick (2015-03-16 12:59:06)
> > > of_device_id is always used as const.
> > > (See driver.of_match_table and open firmware functions)
> > >
> > > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> >
> > Acked-by: Michael Turquette <mturquette@linaro.org>
> 
> Thanks :)
> 
> btw, something I forgot to mention in changelog is the __initdata -> __initconst
> for ti_clkdm_match_table[]
> 
> I can send it again with a new changelog if necessary ...
> 

Did you want us to take this through clk-next? If so please
resend with the new commit text.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 32/35 linux-next] clk: constify of_device_id array

[Fabian Frederick]

> On 27 March 2015 at 08:19 Stephen Boyd <sboyd@codeaurora.org> wrote:
>
>
> On 03/22, Fabian Frederick wrote:
> >
> >
> > > On 18 March 2015 at 15:15 Michael Turquette <mturquette@linaro.org> wrote:
> > >
> > >
> > > Quoting Fabian Frederick (2015-03-16 12:59:06)
> > > > of_device_id is always used as const.
> > > > (See driver.of_match_table and open firmware functions)
> > > >
> > > > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > >
> > > Acked-by: Michael Turquette <mturquette@linaro.org>
> >
> > Thanks :)
> >
> > btw, something I forgot to mention in changelog is the __initdata ->
> > __initconst
> > for ti_clkdm_match_table[]
> >
> > I can send it again with a new changelog if necessary ...
> >
>
> Did you want us to take this through clk-next? If so please
> resend with the new commit text.

Of course :) I hope V2 is ok.

Regards,
Fabian
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project