Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Tony Lindgren <tony@atomide.com>
Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/9] mfd: Drop unnecessary static
Date: Thu,  4 May 2017 22:10:50 +0200	[thread overview]
Message-ID: <1493928654-18768-6-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr>

Drop static on a local variable, when the variable is initialized before
any use, on every possible execution path through the function.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change increases the code size but decreases the size of the bss segment.

before:
   text    data     bss     dec     hex filename
   3369     272     300    3941     f65 drivers/mfd/twl4030-irq.o

after:
   text    data     bss     dec     hex filename
   3401     272      28    3701     e75 drivers/mfd/twl4030-irq.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/mfd/twl4030-irq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index b46c0cf..c775f27 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -683,7 +683,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
 
 int twl4030_init_irq(struct device *dev, int irq_num)
 {
-	static struct irq_chip	twl4030_irq_chip;
+	struct irq_chip	twl4030_irq_chip;
 	int			status, i;
 	int			irq_base, irq_end, nr_irqs;
 	struct			device_node *node = dev->of_node;

  reply	other threads:[~2017-05-04 20:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 20:10 [PATCH 0/9] Drop unnecessary static Julia Lawall
2017-05-04 20:10 ` Julia Lawall [this message]
2017-06-27 23:46   ` [PATCH 5/9] mfd: " Kees Cook
2017-07-03 11:42     ` Lee Jones
2017-07-17 11:01   ` Lee Jones
2017-05-04 20:10 ` [PATCH 6/9] regulator: palmas: " Julia Lawall
2017-05-14 10:13   ` Mark Brown
2017-05-15 10:41     ` Julia Lawall
2017-05-15 10:54       ` Mark Brown
2017-05-23 11:24   ` Applied "regulator: palmas: Drop unnecessary static" to the regulator tree Mark Brown
2017-06-27 23:47 ` [PATCH 0/9] Drop unnecessary static Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493928654-18768-6-git-send-email-Julia.Lawall@lip6.fr \
    --to=julia.lawall@lip6.fr \
    --cc=keescook@chromium.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox