linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: am33xx-l4: fix UART compatible
@ 2025-07-21 17:37 Bruno Thomsen
  2025-07-21 23:29 ` Judith Mendez
  0 siblings, 1 reply; 2+ messages in thread
From: Bruno Thomsen @ 2025-07-21 17:37 UTC (permalink / raw)
  To: linux-omap, devicetree
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bruno Thomsen

Fixes the following dtschema check warning:

serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
	['ti,am3352-uart', 'ti,omap3-uart'] is too long
	'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart']
	'ti,am654-uart' was expected
	from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
 arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi b/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
index d6a143abae5f..cef24aafed1a 100644
--- a/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
@@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET |
 			ranges = <0x0 0x9000 0x1000>;
 
 			uart0: serial@0 {
-				compatible = "ti,am3352-uart", "ti,omap3-uart";
+				compatible = "ti,am3352-uart";
 				clock-frequency = <48000000>;
 				reg = <0x0 0x1000>;
 				interrupts = <72>;
@@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET |
 			ranges = <0x0 0x22000 0x1000>;
 
 			uart1: serial@0 {
-				compatible = "ti,am3352-uart", "ti,omap3-uart";
+				compatible = "ti,am3352-uart";
 				clock-frequency = <48000000>;
 				reg = <0x0 0x1000>;
 				interrupts = <73>;
@@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET |
 			ranges = <0x0 0x24000 0x1000>;
 
 			uart2: serial@0 {
-				compatible = "ti,am3352-uart", "ti,omap3-uart";
+				compatible = "ti,am3352-uart";
 				clock-frequency = <48000000>;
 				reg = <0x0 0x1000>;
 				interrupts = <74>;
@@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET |
 			ranges = <0x0 0xa6000 0x1000>;
 
 			uart3: serial@0 {
-				compatible = "ti,am3352-uart", "ti,omap3-uart";
+				compatible = "ti,am3352-uart";
 				clock-frequency = <48000000>;
 				reg = <0x0 0x1000>;
 				interrupts = <44>;
@@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET |
 			ranges = <0x0 0xa8000 0x1000>;
 
 			uart4: serial@0 {
-				compatible = "ti,am3352-uart", "ti,omap3-uart";
+				compatible = "ti,am3352-uart";
 				clock-frequency = <48000000>;
 				reg = <0x0 0x1000>;
 				interrupts = <45>;
@@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET |
 			ranges = <0x0 0xaa000 0x1000>;
 
 			uart5: serial@0 {
-				compatible = "ti,am3352-uart", "ti,omap3-uart";
+				compatible = "ti,am3352-uart";
 				clock-frequency = <48000000>;
 				reg = <0x0 0x1000>;
 				interrupts = <46>;

base-commit: 89be9a83ccf1f88522317ce02f854f30d6115c41
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: am33xx-l4: fix UART compatible
  2025-07-21 17:37 [PATCH] ARM: dts: am33xx-l4: fix UART compatible Bruno Thomsen
@ 2025-07-21 23:29 ` Judith Mendez
  0 siblings, 0 replies; 2+ messages in thread
From: Judith Mendez @ 2025-07-21 23:29 UTC (permalink / raw)
  To: Bruno Thomsen, linux-omap, devicetree
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley

Hi Bruno,

On 7/21/25 12:37 PM, Bruno Thomsen wrote:
> Fixes the following dtschema check warning:
> 
> serial@0 (ti,am3352-uart): compatible: 'oneOf' conditional failed, one must be fixed:
> 	['ti,am3352-uart', 'ti,omap3-uart'] is too long
> 	'ti,am3352-uart' is not one of ['ti,am64-uart', 'ti,j721e-uart']
> 	'ti,am654-uart' was expected
> 	from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>

Thanks for the patch, I think you forgot to add Kevin Hilman to this
email, but other than that LGTM.

Reviewed-by: Judith Mendez <jm@ti.com>

> ---
>   arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi b/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
> index d6a143abae5f..cef24aafed1a 100644
> --- a/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
> @@ -200,7 +200,7 @@ SYSC_OMAP2_SOFTRESET |
>   			ranges = <0x0 0x9000 0x1000>;
>   
>   			uart0: serial@0 {
> -				compatible = "ti,am3352-uart", "ti,omap3-uart";
> +				compatible = "ti,am3352-uart";
>   				clock-frequency = <48000000>;
>   				reg = <0x0 0x1000>;
>   				interrupts = <72>;
> @@ -1108,7 +1108,7 @@ SYSC_OMAP2_SOFTRESET |
>   			ranges = <0x0 0x22000 0x1000>;
>   
>   			uart1: serial@0 {
> -				compatible = "ti,am3352-uart", "ti,omap3-uart";
> +				compatible = "ti,am3352-uart";
>   				clock-frequency = <48000000>;
>   				reg = <0x0 0x1000>;
>   				interrupts = <73>;
> @@ -1139,7 +1139,7 @@ SYSC_OMAP2_SOFTRESET |
>   			ranges = <0x0 0x24000 0x1000>;
>   
>   			uart2: serial@0 {
> -				compatible = "ti,am3352-uart", "ti,omap3-uart";
> +				compatible = "ti,am3352-uart";
>   				clock-frequency = <48000000>;
>   				reg = <0x0 0x1000>;
>   				interrupts = <74>;
> @@ -1770,7 +1770,7 @@ SYSC_OMAP2_SOFTRESET |
>   			ranges = <0x0 0xa6000 0x1000>;
>   
>   			uart3: serial@0 {
> -				compatible = "ti,am3352-uart", "ti,omap3-uart";
> +				compatible = "ti,am3352-uart";
>   				clock-frequency = <48000000>;
>   				reg = <0x0 0x1000>;
>   				interrupts = <44>;
> @@ -1799,7 +1799,7 @@ SYSC_OMAP2_SOFTRESET |
>   			ranges = <0x0 0xa8000 0x1000>;
>   
>   			uart4: serial@0 {
> -				compatible = "ti,am3352-uart", "ti,omap3-uart";
> +				compatible = "ti,am3352-uart";
>   				clock-frequency = <48000000>;
>   				reg = <0x0 0x1000>;
>   				interrupts = <45>;
> @@ -1828,7 +1828,7 @@ SYSC_OMAP2_SOFTRESET |
>   			ranges = <0x0 0xaa000 0x1000>;
>   
>   			uart5: serial@0 {
> -				compatible = "ti,am3352-uart", "ti,omap3-uart";
> +				compatible = "ti,am3352-uart";
>   				clock-frequency = <48000000>;
>   				reg = <0x0 0x1000>;
>   				interrupts = <46>;
> 
> base-commit: 89be9a83ccf1f88522317ce02f854f30d6115c41


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-21 23:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 17:37 [PATCH] ARM: dts: am33xx-l4: fix UART compatible Bruno Thomsen
2025-07-21 23:29 ` Judith Mendez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).