From: Kyungmin Park <kyungmin.park@samsung.com>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] ARM: OMAP: fix apollon USB device support
Date: Mon, 30 Oct 2006 10:54:54 +0000 (GMT) [thread overview]
Message-ID: <1677409.72261162205698728.JavaMail.weblogic@ep_ml02> (raw)
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
Hi David,
In the previous patch, there's some changes in UDC.
It makes the apollon USB can't work.
After some work, I found that you changed the double-buffering condition. It breaks the apollon behavior.
Please append apollon board condition when we use the pio mode, then don't use double-buffering.
and also fix some compiler warning
ARM: OMAP: fix apollon USB device support
- Add apollon use the non-double-buffering in PIO mode
- fix compiler warning
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
--
diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index ceba0a4..449b76b 100644
--- a/drivers/usb/gadget/omap_udc.c
+++ b/drivers/usb/gadget/omap_udc.c
@@ -2579,6 +2579,7 @@ omap_ep_setup(char *name, u8 addr, u8 ty
* (for more reliable behavior)
*/
if ((!use_dma && (addr & USB_DIR_IN))
+ || machine_is_omap_apollon()
|| cpu_is_omap15xx())
dbuf = 0;
@@ -2963,9 +2964,10 @@ known:
}
create_proc_file();
- device_add(&udc->gadget.dev);
- return 0;
-
+ status = device_add(&udc->gadget.dev);
+ if (!status)
+ return status;
+ /* If fail, fall through */
#ifdef USE_ISO
cleanup3:
free_irq(pdev->resource[2].start, udc);
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
reply other threads:[~2006-10-30 10:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1677409.72261162205698728.JavaMail.weblogic@ep_ml02 \
--to=kyungmin.park@samsung.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox