From: Rob Herring <robh@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jic23@kernel.org, linux-omap@vger.kernel.org, chenhuiz@axis.com,
jean-baptiste.maneyrol@tdk.com, bcousson@baylibre.com,
robh+dt@kernel.org, tony@atomide.com, lars@metafoo.de,
andy.shevchenko@gmail.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: imu: mpu6050: Add level shifter
Date: Sun, 24 Sep 2023 18:33:15 -0500 [thread overview]
Message-ID: <169559839506.3866057.16365029701473740413.robh@kernel.org> (raw)
In-Reply-To: <20230924222559.2038721-2-andreas@kemnade.info>
On Mon, 25 Sep 2023 00:25:57 +0200, Andreas Kemnade wrote:
> Found in ancient platform data struct:
> level_shifter: 0: VLogic, 1: VDD
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml: properties:invensense,level-shifter: True is not of type 'object'
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml: properties:invensense,level-shifter: More than one condition true in oneOf schema:
{'description': 'Vendor specific properties must have a type and '
'description unless they have a defined, common '
'suffix.',
'oneOf': [{'additionalProperties': False,
'description': 'A vendor boolean property can use "type: '
'boolean"',
'properties': {'deprecated': True,
'description': True,
'type': {'const': 'boolean'}},
'required': ['type', 'description']},
{'additionalProperties': False,
'description': 'A vendor string property with exact values '
'has an implicit type',
'oneOf': [{'required': ['enum']}, {'required': ['const']}],
'properties': {'const': {'type': 'string'},
'deprecated': True,
'description': True,
'enum': {'items': {'type': 'string'}}},
'required': ['description']},
{'description': 'A vendor property needs a $ref to '
'types.yaml',
'oneOf': [{'required': ['$ref']}, {'required': ['allOf']}],
'properties': {'$ref': {'pattern': 'types.yaml#/definitions/'},
'allOf': {'items': [{'properties': {'$ref': {'pattern': 'types.yaml#/definitions/'}},
'required': ['$ref']}]}},
'required': ['description']},
{'description': 'A vendor property can have a $ref to a a '
'$defs schema',
'properties': {'$ref': {'pattern': '^#/(definitions|\\$defs)/'}},
'required': ['$ref']}],
'type': 'object'}
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230924222559.2038721-2-andreas@kemnade.info
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-09-24 23:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 22:25 [PATCH 0/3] ARM: omap: omap4-embt2ws: Add IMU on control unit Andreas Kemnade
2023-09-24 22:25 ` [PATCH 1/3] dt-bindings: iio: imu: mpu6050: Add level shifter Andreas Kemnade
2023-09-24 23:33 ` Rob Herring [this message]
2023-09-24 23:39 ` kernel test robot
2023-09-25 6:54 ` Krzysztof Kozlowski
2023-09-25 10:28 ` Jonathan Cameron
2023-09-25 11:02 ` Andreas Kemnade
2023-09-25 12:24 ` Krzysztof Kozlowski
2023-09-25 13:21 ` Jonathan Cameron
2023-09-25 14:25 ` Jean-Baptiste Maneyrol
2023-09-25 18:02 ` Andreas Kemnade
2023-09-24 22:25 ` [PATCH 2/3] iio: imu: mpu6050: add level shifter flag Andreas Kemnade
2023-09-25 11:07 ` Andy Shevchenko
2023-09-25 11:14 ` Jean-Baptiste Maneyrol
2023-09-25 12:04 ` Andreas Kemnade
2023-09-25 12:28 ` Andy Shevchenko
2023-09-24 22:25 ` [PATCH 3/3] ARM: dts: omap: omap4-embt2ws: Add IMU at control unit Andreas Kemnade
2023-09-25 6:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169559839506.3866057.16365029701473740413.robh@kernel.org \
--to=robh@kernel.org \
--cc=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=bcousson@baylibre.com \
--cc=chenhuiz@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox