From: Hangyu Hua <hbh25y@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: kristo@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
tony@atomide.com, claudiu.beznea@microchip.com, robh@kernel.org,
dario.binacchi@amarulasolutions.com, linux-omap@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ti: fix possible memory leak in _ti_omap4_clkctrl_setup()
Date: Wed, 1 Nov 2023 10:30:36 +0800 [thread overview]
Message-ID: <1aec4977-05dd-49dd-ae59-f3fce8db70b7@gmail.com> (raw)
In-Reply-To: <ZUDZ_tDvM7oUBfkq@smile.fi.intel.com>
On 31/10/2023 18:42, Andy Shevchenko wrote:
> On Tue, Oct 31, 2023 at 06:30:10PM +0800, Hangyu Hua wrote:
>> kstrndup() and kstrdup_and_replace() in clkctrl_get_name() can perform
>> dynamic memory allocation. So clkctrl_name needs to be freed when
>> provider->clkdm_name is NULL.
>
>> Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
>> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>> ---
>>
>> v2 and v3: fix commit info.
>
> I believe I gave you my Rb tag. It's your responsibility to care it on if you
> send a new version. Otherwise, please tell what makes you think that tag should
> not be here?
Do you mean "Reviewed-by"? I checked the previous emails and
"lore.kernel.org" and didn’t find this tag in any related emails. I am
not sure what happened. Can you please resend it?
Thanks,
Hangyu
>
prev parent reply other threads:[~2023-11-01 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 10:30 [PATCH v3] ti: fix possible memory leak in _ti_omap4_clkctrl_setup() Hangyu Hua
2023-10-31 10:42 ` Andy Shevchenko
2023-11-01 2:30 ` Hangyu Hua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aec4977-05dd-49dd-ae59-f3fce8db70b7@gmail.com \
--to=hbh25y@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox