linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: Benoit Cousson <b-cousson@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: RE: [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog data to hwmod database.
Date: Wed, 23 Feb 2011 13:44:49 +0530	[thread overview]
Message-ID: <1c7b14958aa88b52095ab07456f96318@mail.gmail.com> (raw)
In-Reply-To: 43067ab756e2e48efb745dee3ecc67eb@mail.gmail.com

Hi Benoit,
>-----Original Message-----
>From: Sricharan R [mailto:r.sricharan@ti.com]
>Sent: Wednesday, February 23, 2011 11:09 AM
>To: Benoit Cousson; Santosh Shilimkar
>Cc: 'linux-omap@vger.kernel.org'; Felipe Balbi
>Subject: RE: [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog data to hwmod
>database.
>
>Hi Benoit,
>>-----Original Message-----
>>From: Cousson, Benoit [mailto:b-cousson@ti.com]
>>Sent: Monday, February 21, 2011 8:10 PM
>>To: Shilimkar, Santosh
>>Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan
>>Subject: Re: [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog data to
hwmod
>>database.
>>
>>Hi Sricharan,
>>
>>On 2/21/2011 2:46 PM, Shilimkar, Santosh wrote:
>>> From: sricharan<r.sricharan@ti.com>
>>>
>>> Add the error log registers, irqs of the l3 interconnect to the
>>> hwmod data. The hwmod change is aligned with Benoit Cousson.
Hi Benoit,
>>
>>The change is almost aligned with Benoit Cousson :-)
>>
>>The subject should be something like: omap4: hwmod data: Add address
>>space and irq in L3 hwmod
>>
>>There is no errolog data in that patch. The changelog should be updated
>>too.
>Ok. I will change the subject and the change log as well.
>>
Here is the updated patch as per your suggestions.

---------------------
[PATCH v2 4/6] omap4: hwmod_data: Add address space and irq in L3 hwmod.

Add the address spaces, irqs of the l3 interconnect to the
hwmod data. The hwmod change is aligned with Benoit Cousson.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: sricharan <r.sricharan@ti.com>
Tested-by: sricharan <r.sricharan@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>
---
changed the subject line and the changelog

 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |   28
++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index c2806bd..95001d4 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -229,11 +229,37 @@ static struct omap_hwmod_ocp_if
omap44xx_l4_cfg__l3_main_1 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };

+/* L3 target configuration and error log registers */
+static struct omap_hwmod_irq_info omap44xx_l3_targ_irqs[] = {
+	{ .irq = 9  + OMAP44XX_IRQ_GIC_START },
+	{ .irq = 10 + OMAP44XX_IRQ_GIC_START },
+};
+
+static struct omap_hwmod_addr_space omap44xx_l3_targ_addrs[] = {
+	{
+		.pa_start	= 0x44000000,
+		.pa_end 	= 0x44100000,
+		.flags		= ADDR_TYPE_RT,
+	},
+	{
+		.pa_start	= 0x44800000,
+		.pa_end		= 0x44900000,
+		.flags		= ADDR_TYPE_RT,
+	},
+	{
+		.pa_start	= 0x45000000,
+		.pa_end		= 0x45100000,
+		.flags		= ADDR_TYPE_RT,
+	},
+};
+
 /* mpu -> l3_main_1 */
 static struct omap_hwmod_ocp_if omap44xx_mpu__l3_main_1 = {
 	.master		= &omap44xx_mpu_hwmod,
 	.slave		= &omap44xx_l3_main_1_hwmod,
 	.clk		= "l3_div_ck",
+	.addr		= omap44xx_l3_targ_addrs,
+	.addr_cnt	= ARRAY_SIZE(omap44xx_l3_targ_addrs),
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };

@@ -248,6 +274,8 @@ static struct omap_hwmod_ocp_if
*omap44xx_l3_main_1_slaves[] = {
 static struct omap_hwmod omap44xx_l3_main_1_hwmod = {
 	.name		= "l3_main_1",
 	.class		= &omap44xx_l3_hwmod_class,
+	.mpu_irqs	= omap44xx_l3_targ_irqs,
+	.mpu_irqs_cnt	= ARRAY_SIZE(omap44xx_l3_targ_irqs),
 	.slaves		= omap44xx_l3_main_1_slaves,
 	.slaves_cnt	= ARRAY_SIZE(omap44xx_l3_main_1_slaves),
 	.omap_chip	= OMAP_CHIP_INIT(CHIP_IS_OMAP4430),
-- 
1.7.0.4

  parent reply	other threads:[~2011-02-23  8:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21 13:46 [PATCH 0/6] omap3/4: Add l3-interconnect error logging support Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 1/6] omap3: hwmod_data: Add l3 error log data to hwmod database Santosh Shilimkar
2011-02-23  8:03   ` Sricharan R
2011-02-23  8:14   ` Sricharan R
2011-02-21 13:46 ` [PATCH 2/6] omap3: Initialise the l3 device with the hwmod data Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 3/6] omap3: l3: Introduce l3-interconnect error handling driver Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 4/6] omap4: hwmod_data: Add l3 errorlog data to hwmod database Santosh Shilimkar
2011-02-21 14:39   ` Cousson, Benoit
2011-02-23  5:38     ` Sricharan R
2011-02-23  8:04     ` Sricharan R
2011-03-04 21:34       ` Cousson, Benoit
2011-03-05  7:51         ` Santosh Shilimkar
2011-02-23  8:14     ` Sricharan R [this message]
2011-02-21 13:46 ` [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data Santosh Shilimkar
2011-02-21 18:10   ` Cousson, Benoit
2011-02-21 19:03     ` Santosh Shilimkar
2011-03-03 18:31       ` Tony Lindgren
2011-03-04  6:20         ` Santosh Shilimkar
2011-03-04 18:08           ` Tony Lindgren
2011-03-05  7:46             ` Santosh Shilimkar
2011-03-07 10:22       ` Cousson, Benoit
2011-03-07 11:19         ` Santosh Shilimkar
2011-03-07 11:25           ` Santosh Shilimkar
2011-02-21 13:46 ` [PATCH 6/6] omap4: l3: Introduce l3-interconnect error handling driver Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c7b14958aa88b52095ab07456f96318@mail.gmail.com \
    --to=r.sricharan@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).