From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] omap24xx mcbsp support
Date: Mon, 21 Nov 2005 10:33:02 -0800
Message-ID: <20051121183302.GE7680@atomide.com>
References: <20051121051735.80492.qmail@web32904.mail.mud.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-omap-open-source-bounces@linux.omap.com>
Content-Disposition: inline
In-Reply-To: <20051121051735.80492.qmail@web32904.mail.mud.yahoo.com>
List-Unsubscribe: <http://linux.omap.com/mailman/listinfo/linux-omap-open-source>,
	<mailto:linux-omap-open-source-request@linux.omap.com?subject=unsubscribe>
List-Archive: <http://linux.omap.com/pipermail/linux-omap-open-source>
List-Post: <mailto:linux-omap-open-source@linux.omap.com>
List-Help: <mailto:linux-omap-open-source-request@linux.omap.com?subject=help>
List-Subscribe: <http://linux.omap.com/mailman/listinfo/linux-omap-open-source>,
	<mailto:linux-omap-open-source-request@linux.omap.com?subject=subscribe>
Sender: linux-omap-open-source-bounces@linux.omap.com
Errors-To: linux-omap-open-source-bounces@linux.omap.com
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
List-Id: linux-omap@vger.kernel.org

* Komal Shah <komal_shah802003@yahoo.com> [051120 21:20]:
> Tony,
> 
> I have added the omap24xx mcbsp support to existing mcbsp framework.
> Only tested with dumping the registers.

OK

> Have you tested the dma chaining on 24xx? Next plan is to add audio and
> touchscreen support taking spi code from 2.6.9 for time being. Once
> audio + ts is tested then we can move to better spi framework from
> spi-devel guys.

No, I've only tested dma with memory-to-memory transfers and MMC on
24xx. So audio would be a good test :)

One comment on the patch below:

> @@ -228,8 +231,10 @@ int omap_mcbsp_request(unsigned int id)
>  	 * On 1510, 1610 and 1710, McBSP1 and McBSP3
>  	 * are DSP public peripherals.
>  	 */
> -	if (id == OMAP_MCBSP1 || id == OMAP_MCBSP3)
> -		omap_mcbsp_dsp_request();
> +	if (cpu_is_omap1510() || cpu_is_omap16xx()) {
> +		if (id == OMAP_MCBSP1 || id == OMAP_MCBSP3)
> +			omap_mcbsp_dsp_request();
> +	}
>  
>  	spin_lock(&mcbsp[id].lock);
>  	if (!mcbsp[id].free) {
> @@ -274,8 +279,10 @@ void omap_mcbsp_free(unsigned int id)
>  	if (omap_mcbsp_check(id) < 0)
>  		return;
>  
> -	if (id == OMAP_MCBSP1 || id == OMAP_MCBSP3)
> -		omap_mcbsp_dsp_free();
> +	if (cpu_is_omap1510() || cpu_is_omap24xx()) {
> +		if (id == OMAP_MCBSP1 || id == OMAP_MCBSP3)
> +			omap_mcbsp_dsp_free();
> +	}
>  
>  	spin_lock(&mcbsp[id].lock);
>  	if (mcbsp[id].free) {

AFAIK 730 and 24xx do not have mcbsp wired to DSP, and only 15xx
and 16xx have it wired to DSP. Then the second chunk above should
probably be also if (cpu_is_omap1510() || cpu_is_omap16xx()) ?

Regards,

Tony