From: Komal Shah <komal_shah802003@yahoo.com>
To: Tony Lindgren <tony@atomide.com>, "Zhang, Jian" <jzhang@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] camera: c99 style structure
Date: Tue, 22 Nov 2005 00:50:04 -0800 (PST) [thread overview]
Message-ID: <20051122085004.71845.qmail@web32907.mail.mud.yahoo.com> (raw)
In-Reply-To: <20051121175231.GB7680@atomide.com>
--- Tony Lindgren <tony@atomide.com> wrote:
> * Zhang, Jian <jzhang@ti.com> [051121 07:20]:
> > Komal,
> >
> > omap16xxcam.c is an OMAP specific file (OMAP1 camera I/F) instead
> of
> > board specific file. I like to keep omap16xxcam.c both board and
> sensor
> > independent. My suggestion is that moving the board code from the
> ov9640
> > sensor driver to board files and calling the board functions from
> the
> > sensor. So the sensor interface is intact.
>
> I like this too.
Yes, but which board file is again a confusion. I don't think
board-hx.c is a good candidate for exporting functions from that. How
about gpio-expandar-omap.c itself? _or_ should we create a new file
under mach-omap1/2 to export this two powerup/down symbols?
---Komal Shah
http://komalshah.blogspot.com/
__________________________________
Yahoo! Mail - PC Magazine Editors' Choice 2005
http://mail.yahoo.com
next prev parent reply other threads:[~2005-11-22 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 15:19 [PATCH] camera: c99 style structure Zhang, Jian
2005-11-21 17:52 ` Tony Lindgren
2005-11-22 8:50 ` Komal Shah [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-23 15:36 Zhang, Jian
2005-11-24 10:47 ` Komal Shah
2005-11-22 14:44 Zhang, Jian
2005-11-23 5:39 ` Komal Shah
2005-11-21 14:00 Komal Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051122085004.71845.qmail@web32907.mail.mud.yahoo.com \
--to=komal_shah802003@yahoo.com \
--cc=jzhang@ti.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox