From: Tony Lindgren <tony@atomide.com>
To: Romain Goyet <r.goyet@gmail.com>
Cc: tony.lindgren@atomide.com, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] FB support for OMAP2
Date: Mon, 28 Nov 2005 18:17:25 -0800 [thread overview]
Message-ID: <20051129021725.GG8319@atomide.com> (raw)
In-Reply-To: <8028e5750511272311r7fb387b2t@mail.gmail.com>
* Romain Goyet <r.goyet@gmail.com> [051127 23:11]:
> .
> After checking, it appeared your patch was just working great : my
> Palm's in fact crashing because of a bug in the function
> paging_init(); in arch/arm/mm/init.c.
>
> 2005/11/28, Imre Deak <imre.deak@nokia.com>:
> > Hi,
> >
> > For me it didn't even build for PALMTE, so this is at least needed:
> >
> > diff --git a/drivers/video/omap/lcdc.c b/drivers/video/omap/lcdc.c
> > index fd5e137..5700d25 100644
> > --- a/drivers/video/omap/lcdc.c
> > +++ b/drivers/video/omap/lcdc.c
> > @@ -439,7 +439,7 @@ static void inline setup_regs(void)
> > #ifdef CONFIG_MACH_OMAP_PALMTE
> > /* FIXME:if (machine_is_omap_palmte()) { */
> > /* PalmTE uses alternate TFT setting in 8BPP mode */
> > - l |= (tft && fbdev->panel->video_mode->bpp == 8) ? 0x810000 : 0;
> > + l |= (is_tft && panel->bpp == 8) ? 0x810000 : 0;
> > /* } */
> > #endif
> > omap_writel(l, OMAP_LCDC_CONTROL);
Pushing this today.
Tony
next prev parent reply other threads:[~2005-11-29 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1129668250.5871.56.camel@mammoth.research.nokia.com>
[not found] ` <4356BD5A.2040100@mvista.com>
[not found] ` <1129799050.5762.6.camel@mammoth.research.nokia.com>
[not found] ` <8028e5750511271548o1c5a213i@mail.gmail.com>
[not found] ` <1133158321.8150.9.camel@localhost.localdomain>
2005-11-28 7:11 ` [PATCH] FB support for OMAP2 Romain Goyet
2005-11-29 2:17 ` Tony Lindgren [this message]
2005-11-29 8:11 ` Romain Goyet
2005-11-29 23:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051129021725.GG8319@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=r.goyet@gmail.com \
--cc=tony.lindgren@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox