From: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] fix watchdog
Date: Mon, 19 Dec 2005 08:31:45 -0800 (PST) [thread overview]
Message-ID: <20051219163145.51444.qmail@web32906.mail.mud.yahoo.com> (raw)
In-Reply-To: <1135009205.12906.28.camel@two.research.nokia.com>
> Why?
>
> Instead of explaining _what_ you do in the patch comments, you should
> explain _why_, especially in the case of a trivial patch like
> this.
Ok, I had made a mistake while generating the patch of omap_wdt.c for
"[PATCH] ARCH: OMAP omap-wdt: use struct platform_driver"
"-static struct device_driver omap_wdt_driver = {
- .name = "omap_wdt",
- .bus = &platform_bus_type,
- .probe = omap_wdt_probe,
- .shutdown = omap_wdt_shutdown,
- .remove = __exit_p(omap_wdt_remove),
- .suspend = omap_wdt_suspend,
- .resume = omap_wdt_resume,
+static struct platform_driver omap_wdt_driver = {
+ .probe = omap_wdt_probe,
+ .remove = omap_wdt_remove,
+ .shutdown = omap_wdt_shutdown,
+ .suspend = omap_wdt_suspend,
+ .resume = omap_wdt_resume,
+ .driver = {
+ .owner = THIS_MODULE,
+ .name = "omap-wdt",
+ },
};
In that I had mistakenly changed original driver name from "omap_wdt"
which matches with one in "devices.c" to "omap-wdt". So, you know the
effect...
The current patch reverts it back....
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
next prev parent reply other threads:[~2005-12-19 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 14:09 [PATCH] fix watchdog Komal Shah
2005-12-19 16:20 ` Juha Yrjölä
2005-12-19 16:31 ` Komal Shah [this message]
2005-12-20 11:25 ` Juha Yrjölä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051219163145.51444.qmail@web32906.mail.mud.yahoo.com \
--to=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox