From: Tony Lindgren <tony@atomide.com>
To: Petukhov Nikolay <palmtt2@mail.ru>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: omap1510 MPU interupt BUG
Date: Tue, 3 Jan 2006 09:55:20 -0800 [thread overview]
Message-ID: <20060103175520.GO6034@atomide.com> (raw)
In-Reply-To: <E1ElqUd-000N2H-00.palmtt2-mail-ru@f37.mail.ru>
* Petukhov Nikolay <palmtt2@mail.ru> [051212 11:03]:
> Hi All.
>
> in file linux-2.6.14-omap2/arch/arm/plat-omap/gpio.c
> in function
> static void gpio_irq_handler(unsigned int irq, struct irqdesc *desc, struct pt_regs *regs)
>
> .......
>
> isr = __raw_readl(isr_reg);
> .......
>
> Note: __raw_readl return 32bit, but MPU have 16 bit registers
>
> example:
> MPU isr=0x0001, but __raw_readl() return isr=0x00010001 -> virtual interrupt 16
> desc_handle_irq(0, d, regs) - handled ok
> desc_handle_irq(16, d, regs) - interrupt handler = NULL
>
> Here patch fix it
>
> diff -Nru linux-2.6.14-omap2/arch/arm/plat-omap/gpio.c
> linux-2.6.14-omap2-palmtt2/arch/arm/plat-omap/gpio.c
>
> --- linux-2.6.14-omap2/arch/arm/plat-omap/gpio.c Sat Dec 10 21:05:46 2005 +++ linux-2.6.14-omap2-palmtt2/arch/arm/plat-omap/gpio.c Sat Dec 10 19:57:30 2005 @@ -758,6 +758,10 @@
> while(1) {
> isr = __raw_readl(isr_reg);
> +#ifdef CONFIG_ARCH_OMAP15XX + if (bank->method == METHOD_MPUIO)
> + isr&=0xffff;
> +#endif !
> _enable_gpio_irqbank(bank, isr, 0);
> _clear_gpio_irqbank(bank, isr);
> _enable_gpio_irqbank(bank, isr, 1);
Can't read this patch because of the bad formatting... Can you please
repost? Maybe sending it as an attachment works better with a web
interface :)
Tony
next prev parent reply other threads:[~2006-01-03 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 16:25 omap1510 MPU interupt BUG Petukhov Nikolay
2006-01-03 17:55 ` Tony Lindgren [this message]
2006-01-06 19:37 ` [PATCH] " Dirk Behme
2006-01-16 8:28 ` palmtt2
2006-01-20 18:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060103175520.GO6034@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=palmtt2@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox