build error on Linux-2.6.15-rc4-omap1

build error on Linux-2.6.15-rc4-omap1

[Hiroki Kaminaga]

Hi,

I'm building linux 2.6.15-rc, and applied Linux-2.6.15-rc4-omap1
on source.

However, when I tried to build for OSK5912, with CONFIG_PM=y (this is default),
following error was emitted.

--
make[2]: *** No rule to make target `arch/arm/mach-omap1/pm.o', needed by `arch/arm/mach-omap1/built-in.o'.  Stop.
make[1]: *** [arch/arm/mach-omap1] Error 2
--

However, on 2.6.14 omap patch, there was no such error when CONFIG_PM=y.

pm.c was in arch/arm/plat-omap/, and below diff, without pm.c (and 
I guess also sleep.c too) had caused this error.


diff -u linux-2.6.{14,15rc}/arch/arm/mach-omap1/Makefile
--- linux-2.6.14/arch/arm/mach-omap1/Makefile
+++ linux-2.6.15rc/arch/arm/mach-omap1/Makefile
@@ -3,7 +3,13 @@
 #
 
 # Common support
-obj-y := io.o id.o clock.o irq.o time.o mux.o serial.o devices.o
+obj-y := io.o id.o clock.o irq.o mux.o serial.o devices.o
+
+obj-$(CONFIG_OMAP_MPU_TIMER)           += time.o
+
+# Power Management
+obj-$(CONFIG_PM) += pm.o sleep.o
+
 led-y := leds.o


I'm currently doing work-around by making symbolic link from plat-omap/pm.c.

Anyone have same build error?


HK.
--

Re: build error on Linux-2.6.15-rc4-omap1

[Todd Poynor]

Hiroki Kaminaga wrote:
..
> make[2]: *** No rule to make target `arch/arm/mach-omap1/pm.o', needed by `arch/arm/mach-omap1/built-in.o'.  Stop.
> make[1]: *** [arch/arm/mach-omap1] Error 2
>..
> I'm currently doing work-around by making symbolic link from plat-omap/pm.c.
> 
> Anyone have same build error?

Yes, I now remember I just worked around it and forgot to send a patch 
here.  I assume pm.c is being moved from plat-omap to mach-omap1 (and a 
future version is destined for mach-omap2), so a patch to move the 
current file to mach-omap1 is needed?

-- 
Todd

Re: build error on Linux-2.6.15-rc4-omap1

[Hiroki Kaminaga]

> > make[2]: *** No rule to make target `arch/arm/mach-omap1/pm.o', needed by `arch/arm/mach-omap1/built-in.o'.  Stop.
> > make[1]: *** [arch/arm/mach-omap1] Error 2
> >..
> > I'm currently doing work-around by making symbolic link from plat-omap/pm.c.
> > 
> > Anyone have same build error?
> 
> Yes, I now remember I just worked around it and forgot to send a patch 
> here.  I assume pm.c is being moved from plat-omap to mach-omap1 (and a 
> future version is destined for mach-omap2), so a patch to move the 
> current file to mach-omap1 is needed?

I'm assuming pm.c (and sleep.S) is same file, and I'm using symbolic link
to work around, so patch just for moving is not necessary. (at least for me...)
I hope it'll be fixed in rc6 (or later) in omap big patch.

Best Regards,


HK.
--

Re: build error on Linux-2.6.15-rc4-omap1

[Tony Lindgren]

* Hiroki Kaminaga <kaminaga@sm.sony.co.jp> [051220 18:34]:
> > > make[2]: *** No rule to make target `arch/arm/mach-omap1/pm.o', needed by `arch/arm/mach-omap1/built-in.o'.  Stop.
> > > make[1]: *** [arch/arm/mach-omap1] Error 2
> > >..
> > > I'm currently doing work-around by making symbolic link from plat-omap/pm.c.
> > > 
> > > Anyone have same build error?
> > 
> > Yes, I now remember I just worked around it and forgot to send a patch 
> > here.  I assume pm.c is being moved from plat-omap to mach-omap1 (and a 
> > future version is destined for mach-omap2), so a patch to move the 
> > current file to mach-omap1 is needed?

Yes, the pm.c is working for omap1 but not for omap2. And they will be
somewhat different.
 
> I'm assuming pm.c (and sleep.S) is same file, and I'm using symbolic link
> to work around, so patch just for moving is not necessary. (at least for me...)
> I hope it'll be fixed in rc6 (or later) in omap big patch.

Hmmm, this should be fixed in the current git tree. At least omap1 with
CONFIG_PM builds fine for me.

Regards,

Tony

Re: build error on Linux-2.6.15-rc4-omap1

[Hiroki Kaminaga]

Hi,

> > make[2]: *** No rule to make target `arch/arm/mach-omap1/pm.o', needed by `arch/arm/mach-omap1/built-in.o'.  Stop.
> > make[1]: *** [arch/arm/mach-omap1] Error 2
> >..
> > I'm currently doing work-around by making symbolic link from plat-omap/pm.c.
> > 
> > Anyone have same build error?
> 
> Yes, I now remember I just worked around it and forgot to send a patch 
> here.  I assume pm.c is being moved from plat-omap to mach-omap1 (and a 
> future version is destined for mach-omap2), so a patch to move the 
> current file to mach-omap1 is needed?

I think this problem is not fixed as of Linux-2.6.15-omap1...

Best Regards,


HK.
--