Re: [PATCH] keypad: platform_data and 24xx support -exp

[Tony Lindgren <tony@atomide.com>]

* Komal Shah <komal_shah802003@yahoo.com> [051210 05:03]:
> Tony/Brian,
> 
> I have attached patch which includes:
> 
> o Modification suggested by Brian Swetland 
> o Added platform_data structure
>    - keymap is moved to appropriate board files.
>    - rows and cols fields are not used in the driver yet.
>    - rep bit is added.
> o IRQ resource
> o Added 24xx+menelaus keypad support - tested.
> 
> TODO/FIXME:
> o appropriate place for test_keymap.
> 
> o Removing NUM_COLS/ROWS #defines and replacing with
> platform_data->rows/cols.
> 
> o Moving request_gpio/free_gpio to board specific file, by introducing
> one function in platform_data ? Is this ok? e.g get/put_gpios. As
> driver should work as module too.
> 
> o How to handle row_/col_gpio_num array and set_/get_gpio_val functions
> ? I want to keep them out of this keypad.c. Any suggestions?

I like this patch, takes care of the keypad mapping problems nicely.
Can you please refresh it?

Tony