Re: [PATCH] 24xx dma patch

[Tony Lindgren <tony@atomide.com>]

Hi,

* Kyungmin Park <kyungmin.park@samsung.com> [060105 23:37]:
> Hi 
> 
> It reads DMA status too early and use callback function.
> It's make dma error on 24xx when playing the music.
> 
> Regards,
> 
> Kyungmin Park
> 
> --
> 
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -866,8 +866,10 @@ static int omap2_dma_handle_ch(int ch)
>  	val = 1 << (ch);
>  	omap_writel(val, OMAP_DMA4_IRQSTATUS_L0);
>  
> -	if (likely(dma_chan[ch].callback != NULL))
> +	if (likely(dma_chan[ch].callback != NULL)) {
> +		status = OMAP_DMA_CSR_REG(ch);
>  		dma_chan[ch].callback(ch, status, dma_chan[ch].data);
> +	}
>  
>  	return 0;
>  }

I don't quite understand this patch; Why does the status need to be read
again?

Tony