Re: [PATCH] McBSP support on omap24xx

Komal Shah
2006-01-14T13:34:49Z

--- Tony Lindgren <tony@atomide.com> wrote:

>
> Thanks, updated for clk_enable and manually merged the mux entries.
> Can
> you please verify?

Ooops. I should have replied to this patch earlier. It already broke
innovator1510 and 730, because of #ifdef in register defines in
mcbsp.h.

It is better to have OMAP2_ prefix for McBSP registers, as per my first
McBSP patch. I will fix this and submit the patch.

Apart from this, McBSP.c getting started looking ugly because of lots
of #ifdefers, it is better to have platform_data/driver support for
this McBSP apis _or_ a small framework.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around