Re: [PATCH] McBSP support on omap24xx

Tony Lindgren
2006-01-15T19:44:43Z

* Komal Shah <komal_shah802003@yahoo.com> [060114 09:40]:
> --- Tony Lindgren <tony@atomide.com> wrote:
>
> >
> > Thanks, updated for clk_enable and manually merged the mux entries.
> > Can
> > you please verify?
>
> Ooops. I should have replied to this patch earlier. It already broke
> innovator1510 and 730, because of #ifdef in register defines in
> mcbsp.h.

Yeah, we should get rid of the ifdefs... With the mux.h now common for
omap1 and omap2, the ifdefs around muxing should not be needed any
longer.

> It is better to have OMAP2_ prefix for McBSP registers, as per my first
> McBSP patch. I will fix this and submit the patch.

OK

> Apart from this, McBSP.c getting started looking ugly because of lots
> of #ifdefers, it is better to have platform_data/driver support for
> this McBSP apis _or_ a small framework.

Yes.

Tony