From: Tony Lindgren <tony@atomide.com>
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] McBSP support on omap24xx
Date: Sun, 15 Jan 2006 11:44:43 -0800 [thread overview]
Message-ID: <20060115194334.GC5905@atomide.com> (raw)
In-Reply-To: <20060114133449.21660.qmail@web32903.mail.mud.yahoo.com>
* Komal Shah <komal_shah802003@yahoo.com> [060114 09:40]:
> --- Tony Lindgren <tony@atomide.com> wrote:
>
> >
> > Thanks, updated for clk_enable and manually merged the mux entries.
> > Can
> > you please verify?
>
> Ooops. I should have replied to this patch earlier. It already broke
> innovator1510 and 730, because of #ifdef in register defines in
> mcbsp.h.
Yeah, we should get rid of the ifdefs... With the mux.h now common for
omap1 and omap2, the ifdefs around muxing should not be needed any
longer.
> It is better to have OMAP2_ prefix for McBSP registers, as per my first
> McBSP patch. I will fix this and submit the patch.
OK
> Apart from this, McBSP.c getting started looking ugly because of lots
> of #ifdefers, it is better to have platform_data/driver support for
> this McBSP apis _or_ a small framework.
Yes.
Tony
next prev parent reply other threads:[~2006-01-15 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0ISN00BRPWM5ID@mmp1.samsung.com>
2006-01-10 10:52 ` [PATCH] 24xx dma patch Komal Shah
2006-01-11 4:52 ` [PATCH] McBSP support on omap24xx Kyungmin Park
2006-01-14 1:27 ` Tony Lindgren
2006-01-14 13:34 ` Komal Shah
2006-01-15 19:44 ` Tony Lindgren [this message]
2006-01-11 4:59 ` [PATCH] 24xx dma patch Kyungmin Park
2006-01-14 1:02 ` Tony Lindgren
2006-01-14 1:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060115194334.GC5905@atomide.com \
--to=tony@atomide.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox