From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] Palm TE Touchscreen and fixes Date: Sun, 15 Jan 2006 12:19:50 -0800 Message-ID: <20060115201949.GF5905@atomide.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: andrzej zaborowski Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org Hi, Good to hear you got things working against the current git tree! * andrzej zaborowski [060115 12:00]: > > - The first one fixes the compilation errors and some clock issues > that made the kernel hang on boot on Palm Tungsten E. While these > changes make the kernel boot and work well with the device, and > hopefully don't affect other devices, I don't know how correct are my > ways of fixing it, as I'm completely inexperienced in kernel insides. Regarding changes to clock.[ch], we should have CLOCK_IN_OMAP1510 and CLOCK_IN_OMAP3XX separate. At least the DSP clocks should not be on 310 because it does not have a DSP AFAIK. They may be also other clocks that are not on 310. Could you please redo the clock.[ch] patch so it adds CLOCK_IN_OMAP3XX, and masks it only for the clocks you think you have on 310? Or if you don't know which clocks are on both 310 and 1510, you could just leave out DSP clocks for now, and enable all other 1510 clocks also for 310. Regards, Tony