Re: [PATCH] keypad platform_data and 24xx support refresh

[Komal Shah <komal_shah802003@yahoo.com>]

--- Juha Yrjölä <juha.yrjola@nokia.com> wrote:

> Looks good, except:
> 
> > +#ifdef CONFIG_MACH_OMAP_H4
> > +#define NUM_ROWS 6
> > +#define NUM_COLS 7
> 
> > +static unsigned int row_gpio_num[NUM_ROWS] = { 88, 89, 124, 11, 6,
> 96 };
> > +static unsigned int col_gpio_num[NUM_COLS] = { 90, 91, 100, 36,
> 12, 97, 98 };
> 
> Why not use the platform_data for this information, too?  It's kind
> of
> bad to assume this for all the 2420 boards.

Yes, it is in my TODO.

http://linux.omap.com/pipermail/linux-omap-open-source/2005-December/005889.html


> 
> >  static int test_keymap[] = {
> >         KEY(0, 0, KEY_F4),
> >         KEY(1, 0, KEY_LEFT),
> 
> This can go away, too.  We'll put it into board-nokia770.c.

Ok.

> 
> > +#ifdef CONFIG_MACH_OMAP_H4
> > +static void set_col_gpio_val(u8 value)
> 
> Not H4 but OMAP2.

Why? If 2430 falls into OMAP2 class then it's EVM design for keyboard
is using TWL4030 i2c interface to read the values. Richard can clarify
on this.

> 
> > +       if (machine_is_omap_h4()) {
> 
> Ditto.

Let's see, depends upon 2430 design, otherwise h4 looks good to me.

> 
> There's also a fairly important patch we haven't published yet.  The
> patch provides a work-around to the "ghost key" problem that happens
> when necessary precautions have not been made in the keypad HW
> design.
> If there are three (or more) keys pressed at the same time, and they
> form a triangle on the keypad matrix, the HW thinks there are some
> extra
> keys pressed.
> 
> Unfortunately I don't have time now to come up with a proper patch,
> but
> I've put our version of the driver here:
> http://jemmari.tky.hut.fi/~jey/omap-keypad.c

Ok, I will try to merge it when I release the new patch. (May be this weekend).

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com