From: Tony Lindgren <tony@atomide.com>
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] fix compile h3
Date: Mon, 16 Jan 2006 10:40:50 -0800 [thread overview]
Message-ID: <20060116184050.GG4511@atomide.com> (raw)
In-Reply-To: <20060114141623.41508.qmail@web32914.mail.mud.yahoo.com>
* Komal Shah <komal_shah802003@yahoo.com> [060114 09:00]:
> Tony,
>
> Patch fixes following error and selects the GPIOEXPANDER for H3 board.
>
> arch/arm/mach-omap1/board-h3.c: In function `h3_transceiver_mode':
> arch/arm/mach-omap1/board-h3.c:253: error: incompatible type for
> argument 1 of `cancel_delayed_work'
> arch/arm/mach-omap1/board-h3.c:254: error: invalid type argument of
> `->'
> arch/arm/mach-omap1/board-h3.c:254: error: invalid type argument of
> `->'
> arch/arm/mach-omap1/board-h3.c:255: error: incompatible type for
> argument 1 of `schedule_work'
> make[1]: *** [arch/arm/mach-omap1/board-h3.o] Error 1
> make: *** [arch/arm/mach-omap1] Error 2
>
> Signed-off-by: Komal Shah <komal_shah802003@yahoo.com>
>
> Sorry for this mistake :(
>
> ---Komal Shah
> http://komalshah.blogspot.com/
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam? Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
Content-Description: 3029636071-fixh3-linking.patch
> diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
> index f17b4ac..e89e4fd 100644
> --- a/arch/arm/mach-omap1/Kconfig
> +++ b/arch/arm/mach-omap1/Kconfig
> @@ -36,6 +36,7 @@ config MACH_OMAP_H2
> config MACH_OMAP_H3
> bool "TI H3 Support"
> depends on ARCH_OMAP1 && ARCH_OMAP16XX
> + select GPIOEXPANDER_OMAP
> help
> TI OMAP 1710 H3 board support. Say Y here if you have such
> a board.
> diff --git a/arch/arm/mach-omap1/board-h3.c b/arch/arm/mach-omap1/board-h3.c
> index 826e741..60311d2 100644
> --- a/arch/arm/mach-omap1/board-h3.c
> +++ b/arch/arm/mach-omap1/board-h3.c
> @@ -250,9 +250,9 @@ static int h3_transceiver_mode(struct de
> {
> struct omap_irda_config *irda_config = dev->platform_data;
>
> - cancel_delayed_work(irda_config->gpio_expa);
> - PREPARE_WORK(irda_config->gpio_expa, set_trans_mode, &mode);
> - schedule_work(irda_config->gpio_expa);
> + cancel_delayed_work(&irda_config->gpio_expa);
> + PREPARE_WORK(&irda_config->gpio_expa, set_trans_mode, &mode);
> + schedule_work(&irda_config->gpio_expa);
>
> return 0;
> }
Thanks, pushing this today.
Tony
prev parent reply other threads:[~2006-01-16 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 14:16 [PATCH] fix compile h3 Komal Shah
2006-01-16 18:40 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060116184050.GG4511@atomide.com \
--to=tony@atomide.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox