Re: Ethernet issue in most recent git?

[Tony Lindgren <tony@atomide.com>]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

* Tony Lindgren <tony@atomide.com> [060119 14:08]:
> * Dirk Behme <dirk.behme@de.bosch.com> [060119 12:13]:
> > 
> > the meaning of __IRQT_RISEDGE and __IRQT_FALEDGE was inverted :( So I
> > think we have to exchange _all_ places in OMAP code where these are used?
> 
> We should be able to just remap them in gpio.c. I believe there's a note
> there somewhere saying that by coincidence the bits are the same in omap
> hw as in irq.h...

I'll push the following patch today:



[-- Attachment #2: patch-gpio-irqtype --]
[-- Type: text/plain, Size: 697 bytes --]

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index efba093..cf5ad29 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -448,11 +448,14 @@ static int _set_gpio_triggering(struct g
 		/* We allow only edge triggering, i.e. two lowest bits */
 		if (trigger & ~IRQT_BOTHEDGE)
 			BUG();
-		/* NOTE: knows __IRQT_{FAL,RIS}EDGE match OMAP hardware */
-		trigger &= 0x03;
 		l = __raw_readl(reg);
 		l &= ~(3 << (gpio << 1));
-		l |= trigger << (gpio << 1);
+		if (trigger == IRQT_RISING)
+			l |= 2 << gpio;
+		else if (trigger == IRQT_FALLING)
+			l |= 1 << gpio;
+		else
+			goto bad;
 		break;
 	case METHOD_GPIO_730:
 		reg += OMAP730_GPIO_INT_CONTROL;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]