From: Tony Lindgren <tony@atomide.com>
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] keypad refresh2
Date: Mon, 23 Jan 2006 09:03:47 -0800 [thread overview]
Message-ID: <20060123170347.GB6263@atomide.com> (raw)
In-Reply-To: <20060123144319.89522.qmail@web32910.mail.mud.yahoo.com>
* Komal Shah <komal_shah802003@yahoo.com> [060123 06:44]:
> --- Juha Yrjölä <juha.yrjola@nokia.com> wrote:
>
> > On Tue, Jan 17, 2006 at 09:43:16AM -0800, ext Komal Shah wrote:
> >
> > > + if (cpu_is_omap24xx() && omap_has_menelaus()) {
> > > + row_gpios[5] = 0;
> > > + col_gpios[2] = 15;
> > > + col_gpios[6] = 18;
> > > + }
> >
> > What's this about? What does the keypad have to do with Menelaus?
>
> The first H4 board came out from TI was not having Menelaus chip. And
> gpio signals were changed in the H4 EVM came out with Menelaus for
> keypad. So only way to differentiate between the two was Menelaus chip
> on the new board.
How about just adding && machine_is_omap_h4() there too?
Tony
next prev parent reply other threads:[~2006-01-23 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 17:43 [PATCH] keypad refresh2 Komal Shah
2006-01-20 9:40 ` Komal Shah
2006-01-20 19:19 ` tony
2006-01-22 22:12 ` Juha Yrjölä
2006-01-23 14:43 ` Komal Shah
2006-01-23 17:03 ` Tony Lindgren [this message]
2006-01-23 17:35 ` Komal Shah
2006-01-24 21:26 ` Juha Yrjölä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060123170347.GB6263@atomide.com \
--to=tony@atomide.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox