From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] keypad refresh2 Date: Mon, 23 Jan 2006 09:03:47 -0800 Message-ID: <20060123170347.GB6263@atomide.com> References: <20060122221251.GA1068@two.research.nokia.com> <20060123144319.89522.qmail@web32910.mail.mud.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20060123144319.89522.qmail@web32910.mail.mud.yahoo.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Komal Shah Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Komal Shah [060123 06:44]: > --- Juha Yrj=F6l=E4 wrote: >=20 > > On Tue, Jan 17, 2006 at 09:43:16AM -0800, ext Komal Shah wrote: > >=20 > > > + if (cpu_is_omap24xx() && omap_has_menelaus()) { > > > + row_gpios[5] =3D 0; > > > + col_gpios[2] =3D 15; > > > + col_gpios[6] =3D 18; > > > + } > >=20 > > What's this about? What does the keypad have to do with Menelaus? >=20 > The first H4 board came out from TI was not having Menelaus chip. And > gpio signals were changed in the H4 EVM came out with Menelaus for > keypad. So only way to differentiate between the two was Menelaus chip > on the new board. How about just adding && machine_is_omap_h4() there too? Tony