* [PATCH 1/2] i2c-omap: Fix i2c_xfer for 1 msg
@ 2006-01-24 12:46 Ladislav Michl
2006-02-02 18:31 ` Ladislav Michl
0 siblings, 1 reply; 4+ messages in thread
From: Ladislav Michl @ 2006-01-24 12:46 UTC (permalink / raw)
To: linux-omap-open-source
omap_i2c_xfer is supposed to return number of messages successfuly
transfered. Remove bogus condition which causes it to fail when
transfering one message.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index fb41255..b021073 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -403,7 +403,7 @@ omap_i2c_xfer(struct i2c_adapter *adap,
break;
}
- if (r == 0 && num > 1)
+ if (r == 0)
r = num;
out:
omap_i2c_disable_clocks(dev);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c-omap: Fix i2c_xfer for 1 msg
2006-01-24 12:46 [PATCH 1/2] i2c-omap: Fix i2c_xfer for 1 msg Ladislav Michl
@ 2006-02-02 18:31 ` Ladislav Michl
2006-02-02 19:26 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Ladislav Michl @ 2006-02-02 18:31 UTC (permalink / raw)
To: linux-omap-open-source
On Tue, Jan 24, 2006 at 01:46:54PM +0100, Ladislav Michl wrote:
> omap_i2c_xfer is supposed to return number of messages successfuly
> transfered. Remove bogus condition which causes it to fail when
> transfering one message.
Ping? Everyone happy with current state of art? :-)
Also could anyone with 15xx test second patch (2/2)? If there are no
objectios I'd like to see both applied :-)
Thanks,
ladis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c-omap: Fix i2c_xfer for 1 msg
2006-02-02 18:31 ` Ladislav Michl
@ 2006-02-02 19:26 ` Tony Lindgren
2006-02-07 5:32 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2006-02-02 19:26 UTC (permalink / raw)
To: Ladislav Michl; +Cc: linux-omap-open-source
* Ladislav Michl <ladis@linux-mips.org> [060202 10:39]:
> On Tue, Jan 24, 2006 at 01:46:54PM +0100, Ladislav Michl wrote:
> > omap_i2c_xfer is supposed to return number of messages successfuly
> > transfered. Remove bogus condition which causes it to fail when
> > transfering one message.
>
> Ping? Everyone happy with current state of art? :-)
Everybody's just busy I'd assume...
> Also could anyone with 15xx test second patch (2/2)? If there are no
> objectios I'd like to see both applied :-)
I'll push them on Friday unless somebody somebody files a complaint.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c-omap: Fix i2c_xfer for 1 msg
2006-02-02 19:26 ` Tony Lindgren
@ 2006-02-07 5:32 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2006-02-07 5:32 UTC (permalink / raw)
To: Ladislav Michl; +Cc: linux-omap-open-source
* Tony Lindgren <tony@atomide.com> [060202 11:33]:
> * Ladislav Michl <ladis@linux-mips.org> [060202 10:39]:
> > On Tue, Jan 24, 2006 at 01:46:54PM +0100, Ladislav Michl wrote:
> > > omap_i2c_xfer is supposed to return number of messages successfuly
> > > transfered. Remove bogus condition which causes it to fail when
> > > transfering one message.
> >
> > Ping? Everyone happy with current state of art? :-)
>
> Everybody's just busy I'd assume...
>
> > Also could anyone with 15xx test second patch (2/2)? If there are no
> > objectios I'd like to see both applied :-)
>
> I'll push them on Friday unless somebody somebody files a complaint.
Just pushed them finally.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-07 5:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-24 12:46 [PATCH 1/2] i2c-omap: Fix i2c_xfer for 1 msg Ladislav Michl
2006-02-02 18:31 ` Ladislav Michl
2006-02-02 19:26 ` Tony Lindgren
2006-02-07 5:32 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox