Re: [PATCH] Convert drivers to new irq trigger modes

["Juha Yrjölä" <juha.yrjola@nokia.com>]

On Wed, Feb 08, 2006 at 08:10:44PM +0100, Dirk Behme wrote:

> >> 	int			irq;
> >>+	int			irq_type;
> >
> >This doesn't seem to be used anywhere.
> 
> To which file do you refer here? isp1301_omap.c, tps65010.c 
> or omap_ts.h? I use irq_type in all of them.

Sorry, that part of the patch was obviously correct.  I don't know what I
was smoking at the time. =)

> >You should be ORring here.  Otherwise you lose the SA_SAMPLE_RANDOM flag.
> 
> It is intended to lose SA_SAMPLE_RANDOM here. 
> SA_SAMPLE_RANDOM is the default and shall be used by 
> request_irq() on boards which don't need special trigger 
> setting. But on boards which need special trigger level 
> setting this shall be overridden by the correct setting.

SA_SAMPLE_RANDOM doesn't have anything to do with triggering.  It's used to
indicate whether an IRQ source can be used to feed the kernel entropy pools. 
If the IRQ in question cannot be considered to happen at random intervals,
the flag must not be set.

Cheers,
Juha