Re: OMAP: Update OMAP keypad driver

[Komal Shah <komal_shah802003@yahoo.com>]

--- Juha Yrjölä <juha.yrjola@nokia.com> wrote:

> 
> I was the one who removed that, since it breaks keypad support on all
> OMAP24xx boards (except H4, I presume) that have Menelaus on them. 
> And
> there are quite a few of those.
> 
> Please submit a patch that moves the stuff above into board-h4.c.
> 

I will submit that patch soon, having some problem in H4 setup right
now.

Before that can't we convert the code below in keypad to

253 down(&kp_enable_mutex);
254 	if (state != kp_enable) {
255 	if (state)
256 		enable_irq(INT_KEYBOARD);
257 	else
258 		disable_irq(INT_KEYBOARD);
259 		kp_enable = state;
260 }
261 up(&kp_enable_mutex);

- Use mutex apis.
- and use platform driver data omap_kp->irq instead of INT_KEYBOARD.

Also as of now, I am not getting interrupt on H4 Menelaus keypad, looks
like due to trigger flags changes...or something else.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com