Re: OMAP: Update OMAP keypad driver

[David Weinehall <tao@acc.umu.se>]

On Fri, Feb 17, 2006 at 07:12:07AM -0800, Komal Shah wrote:
> --- Juha Yrjölä <juha.yrjola@nokia.com> wrote:
> 
> > 
> > I was the one who removed that, since it breaks keypad support on all
> > OMAP24xx boards (except H4, I presume) that have Menelaus on them. 
> > And
> > there are quite a few of those.
> > 
> > Please submit a patch that moves the stuff above into board-h4.c.
> > 
> 
> I will submit that patch soon, having some problem in H4 setup right
> now.
> 
> Before that can't we convert the code below in keypad to
> 
> 253 down(&kp_enable_mutex);
> 254 	if (state != kp_enable) {
> 255 	if (state)
> 256 		enable_irq(INT_KEYBOARD);
> 257 	else
> 258 		disable_irq(INT_KEYBOARD);
> 259 		kp_enable = state;
> 260 }
> 261 up(&kp_enable_mutex);

Either you've indented incorrectly here, or you have a bug.

[snip]


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/