From: Komal Shah <komal_shah802003@yahoo.com>
To: David Weinehall <tao@acc.umu.se>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: OMAP: Update OMAP keypad driver
Date: Fri, 17 Feb 2006 13:06:31 -0800 (PST) [thread overview]
Message-ID: <20060217210632.44544.qmail@web32913.mail.mud.yahoo.com> (raw)
In-Reply-To: <20060217163052.GC20494@vasa.acc.umu.se>
--- David Weinehall <tao@acc.umu.se> wrote:
> > Before that can't we convert the code below in keypad to
> >
> > 253 down(&kp_enable_mutex);
> > 254 if (state != kp_enable) {
> > 255 if (state)
> > 256 enable_irq(INT_KEYBOARD);
> > 257 else
> > 258 disable_irq(INT_KEYBOARD);
> > 259 kp_enable = state;
> > 260 }
> > 261 up(&kp_enable_mutex);
>
> Either you've indented incorrectly here, or you have a bug.
Yes, indentation got lost while I had copy pasted code from Firefox to
e-mail editor, but my point was to use mutex apis and replace
INT_KEYBOARD with platform driver data instead.
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
prev parent reply other threads:[~2006-02-17 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 7:41 OMAP: Update OMAP keypad driver Komal Shah
2006-02-13 8:56 ` Juha Yrjölä
2006-02-17 15:12 ` Komal Shah
2006-02-17 16:30 ` David Weinehall
2006-02-17 21:06 ` Komal Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060217210632.44544.qmail@web32913.mail.mud.yahoo.com \
--to=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=tao@acc.umu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox