public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Komal Shah <komal_shah802003@yahoo.com>
To: linux-omap-open-source@linux.omap.com
Subject: ARM: OMAP: Add external LCD controller support for DSP Gateway
Date: Tue, 21 Feb 2006 12:24:19 -0800 (PST)	[thread overview]
Message-ID: <20060221202419.7898.qmail@web32902.mail.mud.yahoo.com> (raw)

Juha,

+			status = omapfb_unregister_client(omapfb_nb);
+			if (!status)
+				printk("omapfb_unregister_client(): "
+				       "success\n");
+			else
+				printk("omapfb_runegister_client(): "
+				       "failure(%d)\n", status);

You might want to add KERN_WARNING or KERN_INFO for above printks and
other locations of printks in the patch where it is missing.

+	}
+	//printk("calling omapfb_update_window_async()\n");
+	omapfb_update_window_async(&win, fbupd_cb, NULL);

c++ style comment. May be you would like to remove that printk itself.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

                 reply	other threads:[~2006-02-21 20:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060221202419.7898.qmail@web32902.mail.mud.yahoo.com \
    --to=komal_shah802003@yahoo.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox