Re: [PATCH] Make H2 board file compile without irda warning

[Komal Shah <komal_shah802003@yahoo.com>]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

--- Komal Shah <komal_shah802003@yahoo.com> wrote:

> 
> True, the warning will be generated, but I added that check
> considering
> that transceiver_mode function will be active only if we are
> successfully able to request that GPIO. So, I am _not_ sure, but it
> is
> better to #ifdef around the h2_transceiver_mode(...) function. What
> do
> you think?
> 

And here comes the patch.

OMAP: Irda: Remove warning
arch/arm/mach-omap1/board-h2.c:244: warning: 'h2_transceiver_mode'
defined but not used.

Signed-off-by: Komal Shah <komal_shah802003@yahoo.com>

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

[-- Attachment #2: 390387012-h2Irda.patch --]
[-- Type: application/octet-stream, Size: 634 bytes --]

diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
index 680e67e..cbc7674 100644
--- a/arch/arm/mach-omap1/board-h2.c
+++ b/arch/arm/mach-omap1/board-h2.c
@@ -240,6 +240,7 @@ static struct platform_device h2_kp_devi
 
 #define H2_IRDA_FIRSEL_GPIO_PIN	17
 
+#if defined(CONFIG_OMAP_IR) || defined(CONFIG_OMAP_IR_MODULE) 
 static int h2_transceiver_mode(struct device *dev, int state)
 {
 	if (state & IR_SIRMODE)
@@ -249,6 +250,7 @@ static int h2_transceiver_mode(struct de
 
 	return 0;
 }
+#endif
 
 static struct omap_irda_config h2_irda_data = {
 	.transceiver_cap	= IR_SIRMODE | IR_MIRMODE | IR_FIRMODE,

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]