Re: [PATCH] Re: v4l2 camera test app

[Komal Shah <komal_shah802003@yahoo.com>]

--- David Cohen <david.cohen@indt.org.br> wrote:

> Hi,
> 
> I am sending a new version of the camera driver for omap2420. Unlike
> the
> last patch I sent, I am not using those functions from dispc and vout
> that were not applied yet.
> The sensor module should be configured to BT8. The configurations for
> NOBT are in the code, but commented on omap24xxcam_sensor_cc_ctrl
> function. It can be changed if necessary.
> 
> +
> +#include "omap24xxcam.h"
> +
> +#define CAMERA_OV9640
> +#ifdef CAMERA_OV9640
> +#include "ov9640.h"
> +#endif

You may not need to include this. 


> +static void omap24xxcam_sensor_cc_ctrl(struct omap24xxcam_device
> *cam)
> +{
> +	struct v4l2_pix_format *pix = &cam->pix;
> +
> +	DBG;
> +
> +	cam->cc_ctrl =		/*CC_CTRL_NOBT_SYNCHRO | CC_CTRL_NOBT_VS_POL */
> +	    CC_CTRL_BT_CORRECT | CC_CTRL_PAR_MODE_BT8;

As I believe this should come from sensor, I think Jian added this in
the new sensor interface. 


> +		if (!in_atomic()) {
> +			set_current_state(TASK_INTERRUPTIBLE);
> +			schedule_timeout(1);

We can use the new api available which combines this two functions.

> +		CAMDMA_CSDP_WRITE_MODE_POSTED 
> +	      | CAMDMA_CSDP_DST_BURST_EN_64
> +	      | CAMDMA_CSDP_DST_PACKED
> +	      | CAMDMA_CSDP_SRC_BURST_EN_64

Why changing from 16 to 64? vga? 

> +
> +	cam = kmalloc(sizeof(struct omap24xxcam_device), GFP_KERNEL);
> +	if (!cam) {
> +		printk(KERN_ERR CAM_NAME ": could not allocate memory\n");
> +		goto init_error;
> +	}
> +	memset(cam, 0, sizeof(struct omap24xxcam_device));

I like kzalloc.

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com