palmte lcd warnings

palmte lcd warnings

[Komal Shah]

Build warning from lcd panel source - latest omap-git tree.

...
-c -o drivers/video/omap/lcd_palmte.o drivers/video/omap/lcd_palmte.c
drivers/video/omap/lcd_palmte.c:86: warning: initialization from
incompatible pointer type
drivers/video/omap/lcd_palmte.c:87: warning: initialization from
incompatible pointer type
drivers/video/omap/lcd_palmte.c:88: warning: initialization from
incompatible pointer type
drivers/video/omap/lcd_palmte.c:89: warning: initialization from
incompatible pointer type
drivers/video/omap/lcd_palmte.c:90: warning: initialization from
incompatible pointer type
....

---Komal Shah
http://komalshah.blogspot.com/

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: palmte lcd warnings

[andrzej zaborowski]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On 28/03/06, Komal Shah <komal_shah802003@yahoo.com> wrote:
> Build warning from lcd panel source - latest omap-git tree.
>
> ...
> -c -o drivers/video/omap/lcd_palmte.o drivers/video/omap/lcd_palmte.c
> drivers/video/omap/lcd_palmte.c:86: warning: initialization from
> incompatible pointer type
> drivers/video/omap/lcd_palmte.c:87: warning: initialization from
> incompatible pointer type
> drivers/video/omap/lcd_palmte.c:88: warning: initialization from
> incompatible pointer type
> drivers/video/omap/lcd_palmte.c:89: warning: initialization from
> incompatible pointer type
> drivers/video/omap/lcd_palmte.c:90: warning: initialization from
> incompatible pointer type
> ....
>
> ---Komal Shah
> http://komalshah.blogspot.com/
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>

Please find the fix attached. Tested to build and to work.
Regards,
--
balrog 2oo6

Dear Outlook users: Please remove me from your address books
http://www.newsforge.com/article.pl?sid=03/08/21/143258

[-- Attachment #2: lcd_palmte-warnings.patch --]
[-- Type: application/octet-stream, Size: 1196 bytes --]

diff -pNaur linux-omap-2.6-orig/drivers/video/omap/lcd_palmte.c linux-omap-2.6/drivers/video/omap/lcd_palmte.c
--- linux-omap-2.6-orig/drivers/video/omap/lcd_palmte.c	2006-03-22 17:44:53.000000000 +0000
+++ linux-omap-2.6/drivers/video/omap/lcd_palmte.c	2006-03-28 22:55:19.000000000 +0000
@@ -33,33 +33,33 @@
 
 #include "debug.h"
 
-static int palmte_panel_init(struct lcd_panel *panel)
+static int palmte_panel_init(struct omapfb_device *panel)
 {
 	DBGENTER(1);
 	DBGLEAVE(1);
 	return 0;
 }
 
-static void palmte_panel_cleanup(struct lcd_panel *panel)
+static void palmte_panel_cleanup(void)
 {
 	DBGENTER(1);
 	DBGLEAVE(1);
 }
 
-static int palmte_panel_enable(struct lcd_panel *panel)
+static int palmte_panel_enable(void)
 {
 	DBGENTER(1);
 	DBGLEAVE(1);
 	return 0;
 }
 
-static void palmte_panel_disable(struct lcd_panel *panel)
+static void palmte_panel_disable(void)
 {
 	DBGENTER(1);
 	DBGLEAVE(1);
 }
 
-static unsigned long palmte_panel_get_caps(struct lcd_panel *panel)
+static unsigned long palmte_panel_get_caps(void)
 {
 	return 0;
 }
@@ -138,4 +138,3 @@ static void palmte_panel_drv_cleanup(voi
 
 module_init(palmte_panel_drv_init);
 module_exit(palmte_panel_drv_cleanup);
-

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: palmte lcd warnings

[Tony Lindgren]

* andrzej zaborowski <balrog@zabor.org> [060328 15:16]:
> On 28/03/06, Komal Shah <komal_shah802003@yahoo.com> wrote:
> > Build warning from lcd panel source - latest omap-git tree.
> >
> > ...
> > -c -o drivers/video/omap/lcd_palmte.o drivers/video/omap/lcd_palmte.c
> > drivers/video/omap/lcd_palmte.c:86: warning: initialization from
> > incompatible pointer type
> > drivers/video/omap/lcd_palmte.c:87: warning: initialization from
> > incompatible pointer type
> > drivers/video/omap/lcd_palmte.c:88: warning: initialization from
> > incompatible pointer type
> > drivers/video/omap/lcd_palmte.c:89: warning: initialization from
> > incompatible pointer type
> > drivers/video/omap/lcd_palmte.c:90: warning: initialization from
> > incompatible pointer type
> > ....
> >
> > ---Komal Shah
> > http://komalshah.blogspot.com/
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Tired of spam?  Yahoo! Mail has the best spam protection around
> > http://mail.yahoo.com
> > _______________________________________________
> > Linux-omap-open-source mailing list
> > Linux-omap-open-source@linux.omap.com
> > http://linux.omap.com/mailman/listinfo/linux-omap-open-source
> >
> 
> Please find the fix attached. Tested to build and to work.
> Regards,

Pushing this today.

Tony