Re: [PATCH 00/32] Convert ARM to generic irq subsystem

[Tony Lindgren <tony@atomide.com>]

* Thomas Gleixner <tglx@linutronix.de> [060429 03:08]:
> On Fri, 2006-04-28 at 16:17 -0700, Kevin Hilman wrote:
> > ok, I tried with -rc3 and I still dont see any GPIO interrupts.
> > 
> > After looking closer at the IRQ_TYPE_* flags, I noticed that they didn't match 
> > the SA_TRIGGER_* flags for _FALLING or _RISING.  The following patch swaps the 
> > two and make OMAP happy.  It's now booting, and things seem sane.  Will do some 
> > more intensive testing
> > 
> > Kevin
> 
> Sigh. I knew I'd screw that one up.
> 
> Applied and released -rc3-armirq2.

Patches seem to work for me too on various omap boards. Also dyntick
works.

Should this part in kernel/irq/handle.c be CONFIG_ARM for now?

@@ -84,6 +229,15 @@ fastcall int handle_IRQ_event(unsigned i
 	if (!(action->flags & SA_INTERRUPT))
 		local_irq_enable();
 
+#if defined(CONFIG_NO_IDLE_HZ)
+	if (!(action->flags & SA_TIMER) && system_timer->dyn_tick !=
NULL) {
+		write_seqlock(&xtime_lock);
+		if (system_timer->dyn_tick->state & DYN_TICK_ENABLED)
+			system_timer->dyn_tick->handler(irq, 0, regs);
+		write_sequnlock(&xtime_lock);
+	}
+#endif
+
 	do {
 		ret = action->handler(irq, action->dev_id, regs);
 		if (ret == IRQ_HANDLED)

Regards,

Tony