public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix tlv320aic23.c
Date: Wed, 3 May 2006 05:56:07 -0700	[thread overview]
Message-ID: <20060503125606.GG30376@atomide.com> (raw)
In-Reply-To: <4452384E.7080409@gmail.com>

* Dirk Behme <dirk.behme@googlemail.com> [060428 08:45]:
> 
> ARM: OMAP: Fix error from GCC 4.1.0:
> 
> drivers/i2c/chips/tlv320aic23.c:157: error: expected '='
> before '{' token
> drivers/i2c/chips/tlv320aic23.c:161: error: expected '}'
> before '.' token
> 
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
> 
> -- cut, comment not to go into git below --
> 
> Seems that the first part of
> 
> http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=51c0cddf5027bd4e5c1903845047d7d7e266c79b
> 
> was lost somewhere??

> --- ./drivers/i2c/chips/tlv320aic23.c_orig	2006-04-28 17:29:49.000000000 +0200
> +++ ./drivers/i2c/chips/tlv320aic23.c	2006-04-28 17:30:55.000000000 +0200
> @@ -154,7 +154,7 @@ static int aic23_attach_adapter(struct i
>  }
>  
>  static struct i2c_driver aic23_driver = {
> -	.driver {
> +	.driver = {
>  		.name	= "OMAP+TLV320AIC23 codec",
>  		/*.flags	= I2C_DF_NOTIFY,*/
>  	},
> 

Thanks, pushed your patch.

I think the earlier patch chunk has gotten auto-hosed by git merge in
Juha's recent merge:

http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=330c1eb9a689973326cdece277d0b4b409833bb9

Mika & Dirk, can you guys check if some of the other audio files got
hosed or some old audio files got added back?

Regards,

Tony

  reply	other threads:[~2006-05-03 12:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-28 15:44 [PATCH] ARM: OMAP: Fix tlv320aic23.c Dirk Behme
2006-05-03 12:56 ` Tony Lindgren [this message]
2006-05-03 18:41   ` Dirk Behme
2006-05-04 14:51     ` David Brownell
2006-05-04 16:08       ` Undefined usb_disconnect, was " Dirk Behme
2006-05-04 16:32         ` David Brownell
2006-05-05  4:50           ` Undefined usb_disconnect Dirk Behme
2006-05-05  8:08             ` Hiroshi DOYU
2006-05-27  6:38               ` Dirk Behme
2006-05-27 15:43                 ` David Brownell
2006-05-28 13:21                   ` Dirk Behme
2006-05-28 16:17                     ` David Brownell
2006-07-04  8:20                   ` tony
2006-05-03 19:42   ` [PATCH] ARM: OMAP: Fix tlv320aic23.c lamikr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060503125606.GG30376@atomide.com \
    --to=tony@atomide.com \
    --cc=dirk.behme@googlemail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox