From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH 2.6.17-rc3-omap] omap_uwire byteswap bugfix Date: Thu, 4 May 2006 10:07:24 -0700 Message-ID: <200605041007.24948.david-b@pacbell.net> References: <200605022215.49062.david-b@pacbell.net> <20060504145344.GA21933@nokia.com> <200605040818.44126.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_MTjWEM7/lVOdTMN" Return-path: In-Reply-To: <200605040818.44126.david-b@pacbell.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Paul Mundt Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org --Boundary-00=_MTjWEM7/lVOdTMN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thursday 04 May 2006 8:18 am, David Brownell wrote: > On Thursday 04 May 2006 7:53 am, Paul Mundt wrote: > > > This breaks the build, SPI_LSB_FIRST isn't defined anywhere.. > > ... > > Looks like this is missing.. > > > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/spi-devices-can-require-lsb-first-encodings.patch > > > > which isn't in Linus's tree either yet however. > > Whoops, yes. My bad, sorry; it was in _my_ tree and I overlooked how it got there. > I thought maybe Juha had merged it. > > Simplest fix would be to merge that patch from Greg's tree. I take that back. Simplest fix is to remove that code fragment, since an equivalent one -- in the spi_bitbang infrastructure -- is found in that nyet-merged patch. - Dave --Boundary-00=_MTjWEM7/lVOdTMN Content-Type: text/x-diff; charset="us-ascii"; name="omap-uwire-tweak.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="omap-uwire-tweak.patch" Build fix ... the LSB_FIRST option isn't yet merged, and in any case this driver doesn't need it since the LSB_FIRST patch handles it in the spi_bitbang infrastructure used by omap_uwire. Signed-off-by: David Brownell Index: osk/drivers/spi/omap_uwire.c =================================================================== --- osk.orig/drivers/spi/omap_uwire.c 2006-05-03 08:03:40.000000000 -0700 +++ osk/drivers/spi/omap_uwire.c 2006-05-04 10:05:14.000000000 -0700 @@ -317,12 +317,6 @@ static int uwire_setup(struct spi_device goto done; } - if (spi->mode & SPI_LSB_FIRST) { - pr_debug("%s: lsb first?\n", spi->dev.bus_id); - status = -EINVAL; - goto done; - } - /* mode 0..3, clock inverted separately; * standard nCS signaling; * don't treat DI=high as "not ready" --Boundary-00=_MTjWEM7/lVOdTMN Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-00=_MTjWEM7/lVOdTMN--