Re: [PATCH 1/3] Add backlight support for Amstrad Delta

[Tony Lindgren <tony@atomide.com>]

Hi,

Sorry for long delay replaying on this one too.

* Jonathan McDowell <noodles@earth.li> [060429 09:07]:
> On Fri, Apr 28, 2006 at 03:26:38AM -0700, tony@atomide.com wrote:
> > * Jonathan McDowell <noodles@earth.li> [060402 09:38]:
> > > This patch adds support for the Amstrad Delta LCD backlight. It's
> > > the first patch in a series of 3 enabling full LCD support for the
> > > Delta and is the least intrusive, allowing control of the backlight
> > > through the existing backlight class infrastructure.
> > Looks good. Can you please separate
> > arch/arm/mach-omap1/board-ams-delta.c changes and other core omap
> > changes into separate patch in this series?
>  
> Sure. So you'd want it as the following patches:
> 
> * Add the LCD support to drivers/video/omap/
> * Add the support to arch/arm/mach-omap1/board-ams-delta.c for the
>   above.
> * Add the backlight driver to drivers/video/backlight/
> * Add the support to arch/arm/mach-omap1/board-ams-delta.c for the
>   above.
> 
> ?
> 
> Or possibly only the one patch against
> arch/arm/mach-omap1/board-ams-delta.c pulling in both the LCD and
> backlight support? Or should I submit the backlight support to mainline
> given it doesn't touch OMAP specific code?

Yes, please send backlight patches to mainline directly. Then one patch
for drivers/video/omap, one for board-ams-delta, and one for your
defconfig.
 
> Also are you planning to add Mark Underwood's 444 patch, as having that
> there before I rebase my patches would be very useful.

Sorry, do you have a URL for that? Or maybe it's been already applied?

Regards,

Tony