public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan McDowell <noodles@earth.li>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG
Date: Wed, 17 May 2006 18:25:47 +0100	[thread overview]
Message-ID: <20060517172547.GA3778@earth.li> (raw)

I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
it compiles fine without it. This patch removes the Kconfig dependency.

Also the description is wrong; it doesn't hook into the input layer at
all from what I can tell. Are there patches around that add this? The
Amstrad Delta has a phone hook on a GPIO that I plan to support with
this driver and being able to produce a keypress would be nice.

Signed-off-by: Jonathan McDowell <noodles@earth.li>

-----
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 28ca5ad..762d417 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -57,13 +57,12 @@ config OMAP_COMPONENT_VERSION
 
 config OMAP_GPIO_SWITCH
 	bool "GPIO switch support"
-        depends on OMAP_BOOT_TAG
         default n
         help
           Say Y, if you want to have support for input layer reporting
           of GPIO switches (e.g. cover switches). Your bootloader has to
           provide information about the switches to the kernel via the
-          ATAG_BOARD mechanism.
+          ATAG_BOARD mechanism if they're not defined by the board config.
 
 config OMAP_MUX
 	bool "OMAP multiplexing support"
-----

J.

-- 
Web [    I'd love to but... I'm having all my plants neutered.     ]
site: http:// [                                          ]       Made by
www.earth.li/~noodles/  [                      ]         HuggieTag 0.0.23

             reply	other threads:[~2006-05-17 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-17 17:25 Jonathan McDowell [this message]
2006-05-17 17:35 ` [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG Paul Mundt
2006-05-18  8:34 ` Juha Yrjölä
2006-05-18  9:18 ` Jonathan McDowell
2006-05-26 23:17   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060517172547.GA3778@earth.li \
    --to=noodles@earth.li \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox