From: Paul Mundt <paul.mundt@nokia.com>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG
Date: Wed, 17 May 2006 20:35:53 +0300 [thread overview]
Message-ID: <20060517173553.GA4172@nokia.com> (raw)
In-Reply-To: <20060517172547.GA3778@earth.li>
On Wed, May 17, 2006 at 06:25:47PM +0100, Jonathan McDowell wrote:
> I can't see any reason why OMAP_GPIO_SWITCH depends on OMAP_BOOT_TAG;
> it compiles fine without it. This patch removes the Kconfig dependency.
>
It doesn't depend on it specifically itself, no, so I suppose dropping
the dependency is fine.
> Also the description is wrong; it doesn't hook into the input layer at
> all from what I can tell. Are there patches around that add this? The
> Amstrad Delta has a phone hook on a GPIO that I plan to support with
> this driver and being able to produce a keypress would be nice.
>
May as well just remove 'input layer' from the description, it was a
legacy thing..
> Signed-off-by: Jonathan McDowell <noodles@earth.li>
>
Acked-by: Paul Mundt <paul.mundt@nokia.com>
next prev parent reply other threads:[~2006-05-17 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 17:25 [PATCH] ARM: OMAP: OMAP_GPIO_SWITCH doesn't need OMAP_BOOT_TAG Jonathan McDowell
2006-05-17 17:35 ` Paul Mundt [this message]
2006-05-18 8:34 ` Juha Yrjölä
2006-05-18 9:18 ` Jonathan McDowell
2006-05-26 23:17 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517173553.GA4172@nokia.com \
--to=paul.mundt@nokia.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox