From: David Brownell <david-b@pacbell.net>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: OMAP5912 touchscreen irq not working
Date: Wed, 31 May 2006 09:05:31 -0700 [thread overview]
Message-ID: <200605310905.31864.david-b@pacbell.net> (raw)
In-Reply-To: <447DB9CC.2070808@gmail.com>
On Wednesday 31 May 2006 8:44 am, Dirk Behme wrote:
> I think it's wrong to get ads7846_irq() called already while
> init without screen touched? And then this irq seems to be
> locked after first touch.
Locking out after first touch is a problem, of course.
IRQ during init happens with some hardware; I recall
concluding it wasn't a problem here, though the details
of that have been discarded like a used coffee filter.
ISTR one issue is that sampling will trigger an IRQ,
so the driver needs to throttle the IRQs.
> Please correct me if I'm wrong here, but with irq called at
> init without screen touched, then after one touch locked,
> and permanently called ads7846_rx() throwing away all
> samples, it seems to me that there is anything basically
> wrong with this new code? At least on OSK with mistral.
There were glitches related to the problem with irqs not
getting disabled on request, with comments along the lines
of "remove this when the irqs work right" ... I think it's
time to maybe sort that issue out.
That said, this problem did not exist before the GPIO IRQ
patches were merged ... I certainly saw correct IRQ behavior
from my testing.
- Dave
next prev parent reply other threads:[~2006-05-31 16:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 6:33 OMAP5912 touchscreen irq not working Dirk Behme
2006-05-27 15:51 ` David Brownell
2006-05-27 20:10 ` Imre Deak
2006-05-27 22:14 ` David Brownell
2006-05-28 6:02 ` Imre Deak
2006-05-31 15:44 ` Dirk Behme
2006-05-31 16:05 ` David Brownell [this message]
2006-05-31 16:46 ` Imre Deak
2006-06-03 18:41 ` [PATCH] input: ads7846: can't disable filtering [was OMAP5912 touchscreen irq not working] Imre Deak
2006-06-05 12:45 ` Dirk Behme
2006-06-05 14:29 ` Imre Deak
2006-06-05 15:17 ` David Brownell
2006-06-05 16:04 ` Imre Deak
2006-06-05 16:13 ` David Brownell
2006-06-05 15:28 ` [PATCH] input: ads7846: can't disable filtering Dirk Behme
2006-07-04 8:38 ` [PATCH] input: ads7846: can't disable filtering [was OMAP5912 touchscreen irq not working] tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605310905.31864.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox