From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: OMAP5912 touchscreen irq not working Date: Wed, 31 May 2006 09:05:31 -0700 Message-ID: <200605310905.31864.david-b@pacbell.net> References: <4477F2BA.3080907@gmail.com> <44793CF9.2050101@nokia.com> <447DB9CC.2070808@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <447DB9CC.2070808@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Dirk Behme Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org On Wednesday 31 May 2006 8:44 am, Dirk Behme wrote: > I think it's wrong to get ads7846_irq() called already while > init without screen touched? And then this irq seems to be > locked after first touch. Locking out after first touch is a problem, of course. IRQ during init happens with some hardware; I recall concluding it wasn't a problem here, though the details of that have been discarded like a used coffee filter. ISTR one issue is that sampling will trigger an IRQ, so the driver needs to throttle the IRQs. > Please correct me if I'm wrong here, but with irq called at > init without screen touched, then after one touch locked, > and permanently called ads7846_rx() throwing away all > samples, it seems to me that there is anything basically > wrong with this new code? At least on OSK with mistral. There were glitches related to the problem with irqs not getting disabled on request, with comments along the lines of "remove this when the irqs work right" ... I think it's time to maybe sort that issue out. That said, this problem did not exist before the GPIO IRQ patches were merged ... I certainly saw correct IRQ behavior from my testing. - Dave