From: "Juha Yrjölä" <juha.yrjola@solidboot.com>
To: balrogg@gmail.com
Cc: Linux-OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: Suspending with keypad bug (RFC)
Date: Sun, 13 Aug 2006 12:36:41 +0300 [thread overview]
Message-ID: <20060813093641.GA20466@mail.solidboot.com> (raw)
In-Reply-To: <fb249edb0608092155r20c17f5dl6397c3d9d191105b@mail.gmail.com>
Hi,
On Thu, Aug 10, 2006 at 06:55:26AM +0200, andrzej zaborowski wrote:
> Thanks for help! I'm attaching the corrected version, it works nicely.
+ unsigned long flags;
+ spin_lock_irqsave(&omap_kp->suspend_lock, flags);
+
+ if (omap_kp->suspended)
+ return IRQ_HANDLED;
+
+ spin_unlock_irqrestore(&omap_kp->suspend_lock, flags);
Here you are returning with the lock held and IRQs disabled. It should be
like this:
spin_lock_irqsave(&omap_kp->suspend_lock, flags);
if (omap_kp->suspended) {
spin_unlock_irqrestore(&omap_kp->suspend_lock, flags);
return IRQ_HANDLED;
}
spin_unlock_irqrestore(&omap_kp->suspend_lock, flags);
Cheers,
Juha
next prev parent reply other threads:[~2006-08-13 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 23:33 Suspending with keypad bug (RFC) andrzej zaborowski
2006-08-06 19:25 ` Juha Yrjölä
2006-08-10 4:55 ` andrzej zaborowski
2006-08-11 10:04 ` Tony Lindgren
2006-08-13 9:36 ` Juha Yrjölä [this message]
2006-08-17 19:43 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060813093641.GA20466@mail.solidboot.com \
--to=juha.yrjola@solidboot.com \
--cc=balrogg@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox