Re: [PATCH] ARM: OMAP: Add Amstrad Delta platform bits for framebuffer.

[Ladislav Michl <ladis@linux-mips.org>]

On Mon, Aug 14, 2006 at 07:31:19PM +0100, Jonathan McDowell wrote:
> This patch adds the platform file components for the Amstrad Delta LCD
> framebuffer. I have confirmed it works with latest git. The patch to
> clock.c /is/ needed for this to work.
> 
> Signed-Off-By: Jonathan McDowell <noodles@earth.li>
[snip]
> diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> index cc08775..70a5d50 100644
> --- a/arch/arm/mach-omap1/clock.c
> +++ b/arch/arm/mach-omap1/clock.c
> @@ -20,6 +20,7 @@ #include <linux/err.h>
>  #include <linux/clk.h>
>  
>  #include <asm/io.h>
> +#include <asm/mach-types.h>
>  
>  #include <asm/arch/cpu.h>
>  #include <asm/arch/usb.h>
> @@ -756,6 +757,14 @@ #if defined(CONFIG_MACH_OMAP_PERSEUS2) |
>  	omap_writew(omap_readw(OMAP730_PCC_UPLD_CTRL) & ~0x1, OMAP730_PCC_UPLD_CTRL);
>  #endif
>  
> +#ifdef CONFIG_MACH_AMS_DELTA
> +	/* Amstrad Delta wants BCLK high when inactive */
> +	if (machine_is_ams_delta())
> +		omap_writel(omap_readl(ULPD_CLOCK_CTRL) |
> +				(1 << SDW_MCLK_INV_BIT),
> +				ULPD_CLOCK_CTRL);
> +#endif

This #ifdef is not necessary. machine_is_ams_delta() will expand to (0)
when CONFIG_MACH_AMS_DELTA not selected and that if (0) will be
optimized away.

>  	/* Turn off DSP and ARM_TIMXO. Make sure ARM_INTHCK is not divided */
>  	/* (on 730, bit 13 must not be cleared) */
>  	if (cpu_is_omap730())


Best regards,
	ladis